Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[design] Fix view pager inside of bottom sheet dialgog #79

Closed
wax911 opened this issue Nov 24, 2021 · 1 comment
Closed

[design] Fix view pager inside of bottom sheet dialgog #79

wax911 opened this issue Nov 24, 2021 · 1 comment
Labels
🐛 bug Something isn't working 🙊 wontfix This will not be worked on
Milestone
v2.0.0-alpha

Comments

@wax911
Copy link
Member

wax911 commented Nov 24, 2021 •
edited

AniTrend Issue Guidelines

Before opening a new issue, please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.

You may find an answer in already closed issues:
https://github.com/AniTrend/anitrend-v2/issues?q=is%3Aissue+is%3Aclosed

Description of Bug

We have a tabbed bottom sheet using a ViewPager2 and a combination of child elements for each page. It seems like there are some issues with sizing (child nested scroll views will stop scrolling after another tab is inflated)

Reproduction Steps

Maybe linked to material-components/material-components-android#2112

Additional Context

We may have to revert to the standard ViewPager instead of ViewPager2.
See: eu.kanade.tachiyomi.widget.TabbedBottomSheetDialog for suggestions

An alternative is to rebuild this particular component in compose fashion
@wax911 wax911 added the 🐛 bug Something isn't working label Nov 24, 2021
@wax911 wax911 added this to the v2.0.0-alpha milestone Nov 24, 2021
@wax911 wax911 added the 🙊 wontfix This will not be worked on label May 23, 2023
@wax911
Copy link
Member Author

wax911 commented May 23, 2023

We'll migrate this over to compose, safely closing this off

@wax911 wax911 closed this as completed May 23, 2023
@wax911 wax911 changed the title Fix view pager inside of bottom sheet dialgog [design] Fix view pager inside of bottom sheet dialgog May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working 🙊 wontfix This will not be worked on
Projects
anitrend-v2
Status: ✅ Done
Milestone
v2.0.0-alpha
Development

No branches or pull requests
1 participant
@wax911