Skip to content

Commit

Permalink
perf(styles): small CSS injector optimization
Browse files Browse the repository at this point in the history 
do not search for id when it is not required
  • Loading branch information
@Anidetrix
Anidetrix committed Mar 13, 2020
1 parent 34c0542 commit fbdd413
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 19 deletions.
3 changes: 2 additions & 1 deletion src/runtime/inject-css.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,10 @@ export default (css, options = {}) => {

/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);

if (singleTag) {
let id = containers.indexOf(container);

if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down
54 changes: 36 additions & 18 deletions test/__snapshots__/index.test.ts.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -106,9 +107,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -197,9 +199,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -284,9 +287,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -537,9 +541,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -659,9 +664,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -746,9 +752,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -984,9 +991,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -1065,9 +1073,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -1146,9 +1155,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -1230,9 +1240,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -1321,9 +1332,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -1391,9 +1403,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -1461,9 +1474,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -1531,9 +1545,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -1604,9 +1619,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -1674,9 +1690,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down Expand Up @@ -1761,9 +1778,10 @@ var injector_14187a73 = (css, options = {}) => {
/** @type {HTMLStyleElement} */
let styleTag;
let id = containers.indexOf(container);
if (singleTag) {
let id = containers.indexOf(container);
if (id === -1) {
id = containers.push(container) - 1;
styleTags[id] = {};
Expand Down

0 comments on commit fbdd413

Please sign in to comment.