Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: new size based LRU cache & minor fixes #76

Merged
merged 6 commits into from Aug 13, 2023
Merged

add: new size based LRU cache & minor fixes #76

merged 6 commits into from Aug 13, 2023

Conversation

ZhymabekRoman
Copy link
Contributor

Closes #58

@vercel
Copy link

vercel bot commented Jan 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
translate ❌ Failed (Inspect) Jun 27, 2023 0:44am

@ZhymabekRoman
Copy link
Contributor Author

Hmmm, test freezes.

@ZhymabekRoman
Copy link
Contributor Author

So 100 threads seems to be too much for a single-core machine. There are two solutions: use gevent, or use parallelism. I don't know what solution will be eligible for translatepy.

@Animenosekai
Copy link
Owner

So 100 threads seems to be too much for a single-core machine. There are two solutions: use gevent, or use parallelism. I don't know what solution will be eligible for translatepy.

This is weird since Python should really allocate threads if it can

@Animenosekai Animenosekai mentioned this pull request Feb 23, 2023
27 tasks
@ZhymabekRoman
Copy link
Contributor Author

@Animenosekai, So even with a 1 thread pool, Github CI just hangs (link). Maybe we should use asyncio for lru_cache?

@Animenosekai
Copy link
Owner

@Animenosekai, So even with a 1 thread pool, Github CI just hangs (link). Maybe we should use asyncio for lru_cache?

Do you really think it hangs because of the ThreadPool ? Seems weird that GitHub Actions have issues with such a common object

@ZhymabekRoman
Copy link
Contributor Author

Do you really think it hangs because of the ThreadPool ? Seems weird that GitHub Actions have issues with such a common object

I probably came to the wrong conclusion, in fact I did set the thread pool size to zero and there were no changes to the hangs.

@ZhymabekRoman
Copy link
Contributor Author

Test hanging is fixed!

@Animenosekai Animenosekai changed the base branch from main to next August 13, 2023 11:35
@Animenosekai Animenosekai merged commit 42b6910 into Animenosekai:next Aug 13, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New] Size limited LRU cache
2 participants