Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed overlapping #443

Merged
merged 3 commits into from
Jun 8, 2024
Merged

fixed overlapping #443

merged 3 commits into from
Jun 8, 2024

Conversation

samarsajad
Copy link
Contributor

Fixes #425

Description

Fixed the patient portal , doctor section and appointment section. They were overlapping and patient portal section was appearing twice. I also enhanced the CSS for the appointment section to make it go in-line with the rest of the webpage

Related Issues

None

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Before
image
After

image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

GSSoC24

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 1:52pm

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @samarsajad! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@samarsajad
Copy link
Contributor Author

Please review my pull request @Anishkagupta04 @varshith257

@varshith257
Copy link
Collaborator

@samarsajad Can you create a new issue for fixing the responsiveness to the patient portal? or maybe you can go with implementing a blood test feature as it is an important one.

cc: @Anjaliavv51 Have a look and create an issue for it.

@varshith257
Copy link
Collaborator

@samarsajad I think you have deleted the appointment section. Have a look at the PR changes:

            <div class="row">
              <div class="col-md-12 form-group mt-3">

                <select name="hospital" id="hospital" class="form-select">
                  <option value="">Select Hospital</option>
                  <!-- Populate with available hospitals -->
                  <option value="Hospital 1">Hospital 1</option>
                  <option value="Hospital 2">Hospital 2</option>
                  <option value="Hospital 3">Hospital 3</option>

@samarsajad
Copy link
Contributor Author

samarsajad commented Jun 6, 2024

The code for patient portal existed twice just below one another. I deleted one of them as they were the same. Please take a look at the screenshot I attached with my pull request @varshith257 @Anishkagupta04

@samarsajad
Copy link
Contributor Author

@samarsajad I think you have deleted the appointment section. Have a look at the PR changes:

            <div class="row">
              <div class="col-md-12 form-group mt-3">

                <select name="hospital" id="hospital" class="form-select">
                  <option value="">Select Hospital</option>
                  <!-- Populate with available hospitals -->
                  <option value="Hospital 1">Hospital 1</option>
                  <option value="Hospital 2">Hospital 2</option>
                  <option value="Hospital 3">Hospital 3</option>

No it's still there. Please take a look at the screenshot I attached. If you want, I can attach a demo video for the same @varshith257 @Anishkagupta04

@samarsajad
Copy link
Contributor Author

@samarsajad Can you create a new issue for fixing the responsiveness to the patient portal? or maybe you can go with implementing a blood test feature as it is an important one.

cc: @Anjaliavv51 Have a look and create an issue for it.

I can do both , I guess. The more the merrier.

@Anjaliavv51
Copy link
Contributor

@samarsajad Can you create a new issue for fixing the responsiveness to the patient portal? or maybe you can go with implementing a blood test feature as it is an important one.

cc: @Anjaliavv51 Have a look and create an issue for it.

Sure

@varshith257
Copy link
Collaborator

@samarsajad Resolve conflicts

@samarsajad
Copy link
Contributor Author

Resolved the conflicts @varshith257 @Anishkagupta04 Please take a look

@varshith257 varshith257 added gssoc level2 medium (enhancements) labels Jun 8, 2024
@varshith257 varshith257 merged commit bf7e172 into Anishkagupta04:main Jun 8, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Jun 8, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level2 medium (enhancements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Many sections overlapping in the Patient Portal Section
3 participants