Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewport is moved to top left corner after save #394

Closed
Atria1234 opened this issue Dec 18, 2021 · 1 comment · Fixed by #395
Closed

Viewport is moved to top left corner after save #394

Atria1234 opened this issue Dec 18, 2021 · 1 comment · Fixed by #395
Assignees
@Atria1234
Labels
anno canvas Issues affecting the anno canvas enhancement New feature or request in development

Comments

@Atria1234
Copy link
Collaborator

Atria1234 commented Dec 18, 2021 •
edited
Loading

It is done because the layout needs to be normalized before it is saved.
Either:

  • move viewport back to original position after the save is done
  • make a copy of the layout, then normalize and save the copy

Since some players might have used the fact that viewport was reset as a hint that save is done, add star to window title as long as there are unsaved changes.
Atria1234 added a commit to Atria1234/anno-designer that referenced this issue Dec 18, 2021
@Atria1234
Normalization doesn't move the viewport (AnnoDesigner#394)
aeb1d70 
- LayoutVersion is loaded when layout is loaded
- Change of layout version is undoable and therefor counts toward unsaved changes
- Star is shown in the window title when there are unsaved changes
@StingMcRay
Copy link
Contributor

This issue is here because of the conversation on Discord, read down from the following link
https://discord.com/channels/571011757317947406/571064812042321927/921726181399740426

@StingMcRay StingMcRay added anno canvas Issues affecting the anno canvas enhancement New feature or request in development labels Dec 18, 2021
Atria1234 added a commit to Atria1234/anno-designer that referenced this issue Dec 23, 2021
@Atria1234
Normalization doesn't move the viewport (AnnoDesigner#394)
be663b6 
- LayoutVersion is loaded when layout is loaded
- Change of layout version is undoable and therefor counts toward unsaved changes
- Star is shown in the window title when there are unsaved changes
@FroggieFrog FroggieFrog linked a pull request Dec 27, 2021 that will close this issue
Normalization doesn't move the viewport (#394) #395
Merged
1 task
Atria1234 added a commit to Atria1234/anno-designer that referenced this issue Jan 17, 2022
@Atria1234
Normalization doesn't move the viewport (AnnoDesigner#394)
44f280a 
- LayoutVersion is loaded when layout is loaded
- Change of layout version is undoable and therefor counts toward unsaved changes
- Star is shown in the window title when there are unsaved changes
FroggieFrog added a commit that referenced this issue Jun 23, 2022
@Atria1234 @FroggieFrog
Viewport is not moved after save (#395)
ca80b25 
* Common changes
* Normalization doesn't move the viewport (#394)
- LayoutVersion is loaded when layout is loaded
- Change of layout version is undoable and therefor counts toward unsaved changes
- Star is shown in the window title when there are unsaved changes
* faster string compare
- rename converter in xaml to match existing variables (formatting is automatically done by EditorConfig)
- use `EventHandler<T>` instead of custom delegate
* Fixed undoable action being registered during normalization even if no objects were moved
* Fixed inconsistent content of main window title after saving
- version didn't update after Save action
- version didn't show up after SaveAs action
* Restored previous shutdown mode after it was modified

Co-authored-by: FroggieFrog <FroggieFrog@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Atria1234 Atria1234

Labels
anno canvas Issues affecting the anno canvas enhancement New feature or request in development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normalization doesn't move the viewport (#394) Atria1234/anno-designer
2 participants
@Atria1234 @StingMcRay