-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding permissions support #201
Conversation
At the moment this only works for I'm guessing it's because of the hardcoded |
This now works for package individually. The test only covers the package individually. Should I also create for the reverse scenario? |
Hi @ianpogi5 This looks pretty good. Thank you for the effort. I agree, I think for completeness, let's add a test for the not individually packaged case. Just copy that test dir, rename and turn off that flag? Maybe have a And please mention me again, so I get notified. Again, appreciate the PR. |
@jayair No problem. I've added the other test. |
Thank you! I'll cut a release shortly. |
Thank you very much! |
Fixes #92