Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding permissions support #201

Merged
merged 5 commits into from
Feb 28, 2021
Merged

Adding permissions support #201

merged 5 commits into from
Feb 28, 2021

Conversation

ianpogi5
Copy link
Contributor

Fixes #92

@ianpogi5
Copy link
Contributor Author

At the moment this only works for package.individually: false.

I'm guessing it's because of the hardcoded ".webpack/service" in my code.

@ianpogi5
Copy link
Contributor Author

This now works for package individually.

The test only covers the package individually. Should I also create for the reverse scenario?

@jayair
Copy link
Member

jayair commented Feb 27, 2021

Hi @ianpogi5 This looks pretty good. Thank you for the effort.

I agree, I think for completeness, let's add a test for the not individually packaged case. Just copy that test dir, rename and turn off that flag? Maybe have a copy-files and copy-files-individually-packaged case? You can name it either way.

And please mention me again, so I get notified. Again, appreciate the PR.

@jayair jayair added the enhancement New feature or request label Feb 27, 2021
@ianpogi5
Copy link
Contributor Author

@jayair No problem. I've added the other test.

@jayair jayair merged commit 35e80db into AnomalyInnovations:master Feb 28, 2021
@jayair
Copy link
Member

jayair commented Feb 28, 2021

Thank you! I'll cut a release shortly.

@jayair
Copy link
Member

jayair commented Feb 28, 2021

@ianpogi5 ianpogi5 deleted the add-permission branch February 28, 2021 03:38
@ianpogi5
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding permissions support
2 participants