Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use esbuild minimizer #235

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

thomaschaaf
Copy link
Contributor

@thomaschaaf thomaschaaf commented Apr 22, 2021

By using esbuild as a minimizer we are saving time during zipping and uploading. It also helps so that you don't hit the 250 MB limit of lambda. It adds almost no extra time during compilation: https://github.com/privatenumber/minification-benchmarks#d3-v631

Also fixes the esbuild-loader not found error.

@thomaschaaf
Copy link
Contributor Author

@jayair could you create one more canary build?

@jayair jayair added the enhancement New feature or request label Apr 23, 2021
@jayair
Copy link
Member

jayair commented Apr 23, 2021

Oh that's an interesting way to use esbuild here.

@jayair jayair merged commit c9faec2 into AnomalyInnovations:beta Apr 23, 2021
@thomaschaaf thomaschaaf deleted the use-esbuild-minimizer branch April 23, 2021 18:50
@jayair jayair mentioned this pull request Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants