Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug: fork-ts-checker does not ignore tsconfig excluded files #284

Merged
merged 1 commit into from
Feb 14, 2022
Merged

fix bug: fork-ts-checker does not ignore tsconfig excluded files #284

merged 1 commit into from
Feb 14, 2022

Conversation

pkit
Copy link
Contributor

@pkit pkit commented Feb 2, 2022

fixes #283

@jayair jayair added the enhancement New feature or request label Feb 7, 2022
@jayair
Copy link
Member

jayair commented Feb 7, 2022

Thanks for the PR @pkit. We parse the tsconfig here: https://github.com/AnomalyInnovations/serverless-bundle/blob/master/src/webpack.config.js#L86

Maybe we can re-use that for your check?

@pkit
Copy link
Contributor Author

pkit commented Feb 7, 2022

@jayair updated, it's not that elegant but at least it won't parse twice

@jayair
Copy link
Member

jayair commented Feb 14, 2022

Yup looks good. Thanks!

@jayair jayair merged commit ad81fe9 into AnomalyInnovations:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unneeded files cannot be excluded
2 participants
@pkit @jayair