Configurable minification #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love for this to get reviewed & merged soon :( |
|
@jayair Any update on this? I'm working on a PR to improve the NestJS serverless documentation and I really want to use this library, but I need to have this option enabled in order to be able to use the class validator and stuff. |
|
I'd like to see some progress here too. Any maintainer we can notify? |
|
Can we add a quick test for this, document it in the README, and resolve the conflicts? I can merge it. |
|
@jayair Done, please review if okay |
|
Thanks for the pull request. Please update the docs, minifyOptions should be an object, not array. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #286