Conditional forceExclude of aws-sdk based on runtime version
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jayair could i get some 👀 on this please? thank you! cc @warrickhill this is a similar fix to #354 but includes tests 😄, which I didn't actually see your pre-existing PR until after I did this work. |
|
Ok I tweaked this a bit so that the "default config" doesn't hardcode aws-sdk. It's now programatically added in the event the runtime is less than |
|
We currently use our own fork of serverless-bundle because of this. Good work, hope this gets merged! |
|
Thank you for this (and adding the tests)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
nodejs18.xand greater,aws-sdkis no longer included and should be conditionally excluded based on theruntimeversion, instead of being a hardcoded exclude.Fixes:
Ref: https://stackoverflow.com/a/74792625