Change of Image sizing unit and size validation fixes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add: Added new "private" methods to `TermImage`. - `_get_render_size()` - `_pixels_cols()` - `_pixels_lines()` - `_width_height_px()` - Change: Rewrote `TermImage._valid_size()`. - Change: Modified `TermImage._render_image()`. - No more odd heights and half last lines, the last line is now always full. - Change: Modified `rendered_*` properties. - Change: Removed `TermImage._width_compensation`. - Change: Updated comments and doctrings of modified methods and properties.
- Change: Updated docstrings of sizing-related methods and properties. - Change: Updated sizing-related terminologies. - "render size" -> "image size". - "render scale" -> "scale".
- Fix: Removed small-size validation upon setting. - No more checking if is sizes are too small when setting. - Fix: The *scroll* argument of `TermImage._renderer()` (and in turn, `TermImage.draw()`), when `True`, now nullifies vertical allowance during size validation. Complements #12.
AnonymouX47
added
documentation
3 tasks
AnonymouX47
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16
InvalidSizeis no longer raised when vertical allowance is greater than the terminal size even though scroll is set toTrue.TermImage.draw()now nullifies vertical allowance during image size validation.