Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI/TUI error handling #33

Merged
merged 5 commits into from Apr 26, 2022
Merged

CLI/TUI error handling #33

merged 5 commits into from Apr 26, 2022

Conversation

AnonymouX47
Copy link
Owner

@AnonymouX47 AnonymouX47 commented Apr 26, 2022 •
edited

  • Fixes handling of some errors in the CLI and TUI.
    • In CLI mode, the viewer no longer exits immedidately an error occurs while drawing an image. Instead, it notifies the user of the error and moves on to the next image.
    • The rendering failure notification in the TUI now contains the reason for failure.
  • Updates the viewer's exit codes.
  • Includes the viewer's exit codes in the docs.

@AnonymouX47
[tui] Changed TUI rendering failure notification
9a1d66b 
- Change: The notification message now contains the reason for failure.
@AnonymouX47
[cli] Fixed error-handling in CLI mode
3874255 
- Fix: The program no longer exits immedidately an error occurs while drawing an image.
  - Instead, it notifies the user of the error and moves on to the next image.
- Fix: Errors that occur while drawing images in CLI mode are no longer CRITICAL-level.
@AnonymouX47
[cli,tui] Updated exit codes
5fa967d 
- Change: Removed `INVALID_SIZE`.
- Change: Re-shuffled the exit code values.
@AnonymouX47
[docs] Added viewer exit codes to the docs
e9b43bc
@AnonymouX47 AnonymouX47 added documentation Improvements or additions to documentation cli Related to the image viewer's CLI (Not to be used anymore) tui Related to the image viewer's TUI (Not to be used anymore) labels Apr 26, 2022
@AnonymouX47 AnonymouX47 added this to the 0.3.0 milestone Apr 26, 2022
@AnonymouX47 AnonymouX47 merged commit 50cab38 into main Apr 26, 2022
@AnonymouX47 AnonymouX47 deleted the error-handling branch April 26, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cli Related to the image viewer's CLI (Not to be used anymore) documentation Improvements or additions to documentation tui Related to the image viewer's TUI (Not to be used anymore)
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AnonymouX47