TUI grid population performance bump #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix: Resolves intensive performance drop while populating large image grids. - Add: Added `GridListBox._next_index`. - Change: Replaced `GridListBox._grid_contents()` with `GridListBox._update_grid_contents()`. - Change: Drastically improved the performance of populating image grids in the TUI. - The display widget generated per render (while still populating the grid) is only for the cells that are not yet inluded in the `GridListBox`. - The `SimpleListWalker` instance of the `GridListBox` (its `.body` property) is now extended instead of replacing it's contents.
AnonymouX47
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GridListBox.SimpleListWalkerinstance of theGridListBox(its.bodyproperty) is now extended instead of replacing it's contents.