Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style-specific API extensions #47

Merged
merged 10 commits into from
Jun 4, 2022
Merged

Conversation

AnonymouX47
Copy link
Owner

@AnonymouX47 AnonymouX47 commented Jun 3, 2022

  • Improves style-specific error handling:
    • Fixes handling of style-specific errors for subclasses defined outside the package.
    • Adds BaseImageError, GraphicsImageError, TextImageError in .exceptions.
    • Adds .exceptions._style_error() for selection of style-specific exceptions.
  • Implements support for style-specific parameters.
    • Adds _style_args and _check_style_args() to BaseImage.
  • Implements support for style-specific format specification.
    • Adds BasImage._check_syle_format_spec().

- Fix: Handled style-specific errors for subclasses defined outside the package.
- Add: Added `BaseImageError`, `GraphicsImageError`, `TextImageError` in `.exceptions`.
- Add: Added `.exceptions._style_error()` for selection of style-specific exceptions.
- Change: Updated `set_render_style()` and its tests.
- Change: Updated docstrings.
@AnonymouX47 AnonymouX47 added documentation Improvements or additions to documentation enhancement New feature / Improvement suggestion or request lib Related to the library (Not to be used anymore) test Related to the test suite labels Jun 3, 2022
@AnonymouX47 AnonymouX47 added this to the 0.4.0 milestone Jun 3, 2022
- Add: Added `_style_args` and `_check_style_args()` to `BaseImage`.
- Add: Incoporated support for style-specific parameters into `BaseImage.draw()`.
- Add: Added `BaseImage._check_style_format_spec()`.
- Change: Extended the base format spec to include the style-specific section.
- Change: Updated `_check_format_spec()` and `__format__()` in `BaseImage`.
- Change: Made `BaseImage._check_formatting()` a static method.
- Change: Updated type hints and docstrings.
- Add: Incoporated style-specific parameters and format spec into image iteration and animation.
- Change: Updated `ImageIterator` and `BaseImage._display_animated()`.
This partially reverts commit 034d7dc.
- Add: Added general tests for style-specific parameters and format specification.
@AnonymouX47 AnonymouX47 added the cli Related to the image viewer's CLI (Not to be used anymore) label Jun 4, 2022
- Change: The full original style-specific format specification is now reported instead of a part of it.
@AnonymouX47 AnonymouX47 merged commit 43ac1ce into main Jun 4, 2022
@AnonymouX47 AnonymouX47 deleted the style-specific-extensions branch June 4, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the image viewer's CLI (Not to be used anymore) documentation Improvements or additions to documentation enhancement New feature / Improvement suggestion or request lib Related to the library (Not to be used anymore) test Related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant