-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style-specific API extensions #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix: Handled style-specific errors for subclasses defined outside the package. - Add: Added `BaseImageError`, `GraphicsImageError`, `TextImageError` in `.exceptions`. - Add: Added `.exceptions._style_error()` for selection of style-specific exceptions. - Change: Updated `set_render_style()` and its tests. - Change: Updated docstrings.
- Add: Added `_style_args` and `_check_style_args()` to `BaseImage`. - Add: Incoporated support for style-specific parameters into `BaseImage.draw()`.
- Add: Added `BaseImage._check_style_format_spec()`. - Change: Extended the base format spec to include the style-specific section. - Change: Updated `_check_format_spec()` and `__format__()` in `BaseImage`. - Change: Made `BaseImage._check_formatting()` a static method. - Change: Updated type hints and docstrings.
- Add: Incoporated style-specific parameters and format spec into image iteration and animation. - Change: Updated `ImageIterator` and `BaseImage._display_animated()`.
This partially reverts commit 034d7dc.
- Add: Added general tests for style-specific parameters and format specification.
- Change: The full original style-specific format specification is now reported instead of a part of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cli
Related to the image viewer's CLI (Not to be used anymore)
documentation
Improvements or additions to documentation
enhancement
New feature / Improvement suggestion or request
lib
Related to the library (Not to be used anymore)
test
Related to the test suite
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseImageError
,GraphicsImageError
,TextImageError
in.exceptions
..exceptions._style_error()
for selection of style-specific exceptions._style_args
and_check_style_args()
toBaseImage
.BasImage._check_syle_format_spec()
.