-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'kitty' render style improvements #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add: Added `method` style arg to `KittyImage`. - Add: Added render method override field to 'kitty' style format spec. - Change: Updated 'kitty' style-specific format specification docs.
- Change: Added render method override to 'kitty' style format specs for the best performance across different terminal emulators.
- Fix: Corrected tests for `z_index` and `mix` style args. - Add: Added tests for `method` style arg and format spec field.
d9d0b80
to
bc146ee
Compare
- Add: Added `compress` style-specific parameter. - Add: Added style format spec field for `compress` style arg. - Change: Modified `.image.kitty.Transmission`. - Added the *level* field for the payload compression level.
- Change: For LINES method, writing chunks directly to the buffer instead of joining all chunks first and then writing to the buffer.
- Add: Added `--kitty-compress` style-specific CL option. - Add: Added *style_args* parameter to `.tui.init()`. - Style-specific args specified at the CL are now being passed to the TUI. - Add: Added 'kitty' `compress` style parameter to the style-specific format specs for the TUI.
- Change: Updated description of 'kitty' `z_index` style arg and CL option.
AnonymouX47
added a commit
that referenced
this pull request
Jun 17, 2022
- Add: Added tests for `compress` style arg and format spec field. - Change: Removed unncessary arguments in existing style arg tests. Completes #51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cli
Related to the image viewer's CLI (Not to be used anymore)
documentation
Improvements or additions to documentation
enhancement
New feature / Improvement suggestion or request
lib
Related to the library (Not to be used anymore)
test
Related to the test suite
tui
Related to the image viewer's TUI (Not to be used anymore)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #40
method
style arg toKittyImage
.compress
style arg toKittyImage
.--kc/--kitty-compress
style-specific CL option.