Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'kitty' render style improvements #51

Merged
merged 9 commits into from
Jun 17, 2022
Merged

'kitty' render style improvements #51

merged 9 commits into from
Jun 17, 2022

Conversation

AnonymouX47
Copy link
Owner

@AnonymouX47 AnonymouX47 commented Jun 14, 2022

Continues #40

  • Implements render method override for 'kitty' render style.
    • Adds method style arg to KittyImage.
    • Adds render method override field to 'kitty' style format spec.
  • Implements ZLIB compression level control for 'kitty' render style.
    • Adds compress style arg to KittyImage.
    • Adds compression level field to 'kitty' style format spec.
    • Adds --kc/--kitty-compress style-specific CL option.
  • Improves 'kitty' style render method selection for best drawing performance in different terminal emulators, in the CLI and TUI.

- Add: Added `method` style arg to `KittyImage`.
- Add: Added render method override field to 'kitty' style format spec.
- Change: Updated 'kitty' style-specific format specification docs.
@AnonymouX47 AnonymouX47 added documentation Improvements or additions to documentation enhancement New feature / Improvement suggestion or request lib Related to the library (Not to be used anymore) cli Related to the image viewer's CLI (Not to be used anymore) tui Related to the image viewer's TUI (Not to be used anymore) test Related to the test suite labels Jun 14, 2022
@AnonymouX47 AnonymouX47 added this to the 0.4.0 milestone Jun 14, 2022
- Change: Added render method override to 'kitty' style format specs for the best performance across different terminal emulators.
- Fix: Corrected tests for `z_index` and `mix` style args.
- Add: Added tests for `method` style arg and format spec field.
@AnonymouX47 AnonymouX47 force-pushed the kitty-updates branch 2 times, most recently from d9d0b80 to bc146ee Compare June 15, 2022 08:06
- Add: Added `compress` style-specific parameter.
- Add: Added style format spec field for `compress` style arg.
- Change: Modified `.image.kitty.Transmission`.
  - Added the *level* field for the payload compression level.
- Change: For LINES method, writing chunks directly to the buffer instead of joining all chunks first and then writing to the buffer.
- Add: Added `--kitty-compress` style-specific CL option.
- Add: Added *style_args* parameter to `.tui.init()`.
  - Style-specific args specified at the CL are now being passed to the TUI.
- Add: Added 'kitty' `compress` style parameter to the style-specific format specs for the TUI.
- Change: Updated description of 'kitty' `z_index` style arg and CL option.
@AnonymouX47 AnonymouX47 merged commit 2d4db51 into main Jun 17, 2022
AnonymouX47 added a commit that referenced this pull request Jun 17, 2022
- Add: Added tests for `compress` style arg and format spec field.
- Change: Removed unncessary arguments in existing style arg tests.

Completes #51
@AnonymouX47 AnonymouX47 deleted the kitty-updates branch June 17, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the image viewer's CLI (Not to be used anymore) documentation Improvements or additions to documentation enhancement New feature / Improvement suggestion or request lib Related to the library (Not to be used anymore) test Related to the test suite tui Related to the image viewer's TUI (Not to be used anymore)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant