Fixes and improvements for the CLI and TUI #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix: Directory checking in non-multiprocessing mode now ends immediately, upon interruption. - Fix: Queues used by getter, opener and checker threads/subprocesses are now purged upon interruption. - Eliminates deadblocks that used to occur sometimes. - Fix: Upon interruption while processing sources, getter, opener and checker threads are always joined to ensure logs are in the correct order. - Fix: Corrected typos in comments. - Change: `.cli.check_dir()` now returns immediately, upon interruption, when running in any non-main thread of the main process. - Change: Delayed startup of getter, opener and checker threads/subprocesses. - Each group is not started until a related source is encountered. - Significantly reduces startup time when multiprocessing is enabled. - Change: Moved `.tui.render.clear_queue()` to `.utils.clear_queue()`.
- Fix: Eliminated style support detection queries in subprocess. - Support is now always enabled and required class attributes are exported. - Support detection used to fail at times. - Fix: Corrected typo. - Add: Added `.logging_multi.exported_style_attrs`. - Add: Added `_style_attrs` instance attribute to `.logging_multi.Process`. - Change: Removed `_force_style` instance attribute of `.logging_multi.Process`.
AnonymouX47
added
enhancement
- Change: Changed module-scope variables in `.keys` to widget instance attributes. - `key_bar_is_collapsed` -> `key_bar._ti_collapsed`. - `expand_key_is_shown` -> `expand._ti_shown`. - Eliminates use of the `global` keyword.
- Fix: Handled all errors when loading and storing user config. - Fix: Handled errors when backing up previous user config during update. - The config file is not overwritten when backup fails. - Fix: Fixed string interpolation in fatal message. - Change: No longer writing config file immediately after updating since it'll still be stored later. - Change: Changed color of error and fatal messages. - Change: Updated docstrings and comments.
Conflicts: term_image/cli.py term_image/logging_multi.py
- Fix: 'kitty' and 'iterm2' images no longer disappear when vertically resizing Konsole. - Was due to the fact that SIGWINCH is rapidly and consistently sent to the process, trigerring rapid redraws. - Fix: Corrected the names of some "private" `GridListbox` instance attributes.
AnonymouX47
force-pushed
the
cli-tui-updates
branch
from
9787822
to
69c4c25
Compare
Conflicts: CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.cli.check_dir()now returns immediately, upon interruption, when running in any non-main thread of the main process.clear_queue()from.tui.renderto.utils.