Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node server capability close #1 #3

Closed

Conversation

DrewMcArthur
Copy link
Contributor

This adds the possibility for running the server with the usage of node.js. Adds the app.js file (the server itself) and the package.json file, which manages dependencies. Getting the server running on a local machine is as easy as five lines in a Linux terminal. This is useful for people who want to set up the server on their own computer, to test changes to the code.

These changes shouldn't affect how the server is running currently, and therefore shouldn't have any effect on CoopGameMaking.com, however it will make the testing process easier for those familiar with node.

@DrewMcArthur
Copy link
Contributor Author

There is an issue in that the save and load buttons don't work for server communication when being run by node. However, since this should be primarily used as a testing server, the issue isn't too important. When this gets merged, I'll add that as an issue that I can look into.

@ghost
Copy link

ghost commented May 7, 2015

Don't you think express is a little too heavy for what is needed.

I find static-serve can do what we need and only has 4 package dependencies as opposed to express's 24 dependencies.

I don't know if you can have a pull request on top of a pull request, but I'd like to have a go at solving the Save/Load events on a Node server. At the same time I'd also like to use static-serve instead of express.

@ghost ghost mentioned this pull request May 7, 2015
@DrewMcArthur
Copy link
Contributor Author

I'm not all that knowledgeable with node, I just know that this works. If your PR is the better option in terms of usability, then I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant