Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brief Verb Not Working #32

Closed
11 tasks done
tajmone opened this issue Oct 24, 2018 · 3 comments
Closed
11 tasks done

Brief Verb Not Working #32

tajmone opened this issue Oct 24, 2018 · 3 comments
Assignees
Labels
🕑 implemented ✔️ Issue dealt with/solved 💀 bug Something isn't working

Comments

@tajmone
Copy link
Collaborator

tajmone commented Oct 24, 2018

  • StdLib Sources — remove brief and verbose and all references to them:
    • lib_definitions.i:
      • CAN 'brief'/verbose
      • MAKE my_game 'brief'/verbose
    • lib_verbs.i:
      • Verbs Table
      • SYNTAX brief/verbose
      • META VERB brief/verbose
  • Test Suite — remove any tests on brief and verbose:
    • tests/misc/meta-verbs.a3sol
  • StdLib Manual — remove brief and verbose and all references to them:
    • Manual contents and examples.
    • table_verbs.dsv (Verbs Table, CSV source)
  • Extras — remove brief and verbose and all references to them:
    • mygame_import.i
    • readme.txt

Ciao Annsi,

I've tested commenting out the Entered part in lib_locations.i:

ADD TO EVERY LOCATION
  HAS visited 0.
  HAS described 0.

--  ENTERED
--     IF CURRENT ACTOR = hero
--      THEN
--        INCREASE visited OF THIS.
--        INCREASE described OF THIS.
--        -- The "described" attribute increases also after LOOK (see 'verbs.i').
--     END IF.

END ADD TO.

and, as we suspected, that makes the brief verb work as expected.

So, unless we can come up with another way to track the number of visits and description of each location, we'll have to either remove from the library the brief and verbose commands, or renounce to the visited and described attributes — personally, I see more value in the latter, so if I had to choose I'd definitely give up brief. These two attributes are too useful to renounce.

Before removing those two verbs, do you have any idea of how the situation could be fixed?

Frankly, I don't see many solutions, as tracking location's visits somewhere else other than the location itself doesn't seem feasabile. At least, I can't think of any solution right now.

@tajmone tajmone added the 💀 bug Something isn't working label Oct 24, 2018
@AnssiR66
Copy link
Owner

AnssiR66 commented Oct 25, 2018 via email

@tajmone tajmone added this to the Release 2.2 milestone Nov 7, 2018
@tajmone tajmone added the 🕑 pending decision Issue/solution still being evaluated label Feb 8, 2019
@tajmone tajmone added this to To do in StdLib 2.2 Dev via automation Apr 15, 2019
@tajmone
Copy link
Collaborator Author

tajmone commented May 29, 2019

@AnssiR66, you should decide what to do with the brief and verbose commands, i.e. if dropping them altogether from the library. Chances are that these won't work even in the future, because from the discussion with Thomas it's clear that it's an intended feature that Alan should ignore the value of VISITS when a location attributes change — which makes sense in most contexts.

Both the StdLib Manual and the Cookbook should be amended in various places where brief and verbose are mentioned. After all, one of the main purposes of the upcoming Lib 2.2 release is to update all the documentation to match the current state of the Library, and find/resolve all pending bugs in both code and documentation.

@tajmone tajmone added the 🕑 pending approval Issue/work blocked until approved by Anssi label Jun 13, 2019
tajmone added a commit to tajmone/Alan3-Italian that referenced this issue Jun 15, 2019
Elimina Verbi Modalità Breve/Lunga

Eliminati i verbi di partita `modalità_breve` e `modalità_lunga` (e gli
attributi di restrizione connessi) dato che il comando "modalità breve"
non funzionava e non avrebbe mai potuto funzionare.

Per maggiori info, vedi:

* AnssiR66/AlanStdLib#32
tajmone added a commit to tajmone/Alan3-Italian that referenced this issue Jun 15, 2019
Eliminati i verbi di partita `modalità_breve` e `modalità_lunga` (e gli
attributi di restrizione connessi) dato che il comando "modalità breve"
non funzionava e non avrebbe mai potuto funzionare.

Per maggiori info, vedi:

* AnssiR66/AlanStdLib#32
@AnssiR66
Copy link
Owner

Yes, let's get rid of brief and verbose. I think 'brief' is very archaic anyway.

@tajmone tajmone added 🕑 pending implementation Approved changes waiting to be implemented and removed 🕑 pending approval Issue/work blocked until approved by Anssi 🕑 pending decision Issue/solution still being evaluated labels Aug 31, 2020
@tajmone tajmone added 🕑 WIP Work In Progress and removed 🕑 pending implementation Approved changes waiting to be implemented labels Sep 9, 2020
tajmone added a commit that referenced this issue Sep 9, 2020
Delete from the Library sources the meta verbs `brief` and `verbose`,
their `my_agame` attributes (actions restrictions), and any references
to them in the Verbs Table and other comments. (See #32)

Also remove `brief` and `verbose` from `StdLib/mygame_import.i` and any
reference to them in `StdLib/readme.txt`. (See #32)

Fix header comments in all library files to `v2.2.0-WIP`:

    -- ALAN Standard Library v2.2.0-WIP | ALAN 3.0beta7
tajmone added a commit that referenced this issue Sep 9, 2020
Drop from the test suite all tests for `brief` and `verbose`. (See #32)
Run again the test suit with new ALAN 3.0beta7 release.
@tajmone tajmone added 🕑 implemented ✔️ Issue dealt with/solved and removed 🕑 WIP Work In Progress labels Sep 9, 2020
tajmone added a commit that referenced this issue Sep 9, 2020
Remove from the StdLib Manual all references to `brief` and `verbose`,
now dropped from the library. (closes #32)

Rebuild all docs using the new ALAN 3.0beta7 release.
@tajmone tajmone closed this as completed Sep 9, 2020
StdLib 2.2 Dev automation moved this from To do to Done Sep 9, 2020
tajmone added a commit that referenced this issue Sep 9, 2020
Remove from the StdLib Manual all references to `brief` and `verbose`,
now dropped from the library. (closes #32)

Rebuild all docs using the new ALAN 3.0beta7 release.
tajmone added a commit that referenced this issue Sep 14, 2020
Remove from the StdLib Manual all references to `brief` and `verbose`,
now dropped from the library. (closes #32)

Rebuild all docs using the new ALAN 3.0beta7 release.
tajmone added a commit that referenced this issue Sep 14, 2020
Remove from the StdLib Manual all references to `brief` and `verbose`,
now dropped from the library. (closes #32)

Rebuild all docs using the new ALAN 3.0beta7 release.
tajmone added a commit that referenced this issue Sep 15, 2020
Delete from the Library sources the meta verbs `brief` and `verbose`,
their `my_agame` attributes (actions restrictions), and any references
to them in the Verbs Table and other comments. (See #32)

Also remove `brief` and `verbose` from `StdLib/mygame_import.i` and any
reference to them in `StdLib/readme.txt`. (See #32)

Fix header comments in all library files to `v2.2.0-WIP`:

    -- ALAN Standard Library v2.2.0-WIP | ALAN 3.0beta7
tajmone added a commit that referenced this issue Sep 15, 2020
Drop from the test suite all tests for `brief` and `verbose`. (See #32)
Run again the test suit with new ALAN 3.0beta7 release.
tajmone added a commit that referenced this issue Sep 15, 2020
Remove from the StdLib Manual all references to `brief` and `verbose`,
now dropped from the library. (closes #32)

Rebuild all docs using the new ALAN 3.0beta7 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕑 implemented ✔️ Issue dealt with/solved 💀 bug Something isn't working
Projects
Development

No branches or pull requests

2 participants