Add all parameters to the SSL module #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class SSLModule(common.Module): | ||
| """Bindings to API methods in the SSL module.""" | ||
|
|
||
| def search_product(self, limit=100, offset=0, **kw): | ||
| def search_product(self, limit=100, offset=0, with_price=0, with_supported_software=0, | ||
| with_description=0): |
There was a problem hiding this comment.
Nee, als alles expliciet is lijkt me dat niet meer nodig.
There was a problem hiding this comment.
Als je niet bekend bent met de API heb je niet echt een mentaal model van alles, dus dat is dan wat lastig te beoordelen :).
blubber
added a commit
that referenced
this pull request
Oct 29, 2015
Add all parameters to the SSL module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.