Apply DeepScan recommended changes #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add me command
Update version to 1.3.14
Update version to 1.3.15
add topgg stats
Update version to 1.3.16
Update to version 1.3.17
add beta message
split the options at '
Prior to this commit, the unBan* commands returned `undefined`, but the function's return value was being treated as a boolean. Return statements have been added to make these work as intended.
|
changed the base branch from |
|
Node.js CI always fails on DeepSource is reporting issues w.r.t. certain variables not being defined. In practice, this isn't a problem because the way the codebase is organized, they'll always be defined by the time that code runs. I think they're useful, though, because it gives indicators of where the codebase could benefit from reorganization. DeepScan helped find some bugs in the unBan* commands due to the way certain promises were being resolved - pretty helpful! |
This was referenced Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to test this remotely, due to lacking API keys etc. However, these were some relatively minor and simple-to-implement changes, so I don't expect any debugging is necessary.