Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(disk-usage): fix bug on variants #1915

Merged
merged 4 commits into from Jan 31, 2024
Merged

Conversation

MartinBelthle
Copy link
Contributor

@MartinBelthle MartinBelthle commented Jan 30, 2024

If the study is a variant, it's possible that it only exists in db and not on disk.
If so, we used to throw a HTTP 500 Exception. Now, we return 0.

Copy link
Collaborator

@laurent-laporte-pro laurent-laporte-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the calculation of the size occupied by a variant when the variant has a snapshot does not work. This needs to be diagnosed and corrected.

antarest/study/service.py Show resolved Hide resolved
@MartinBelthle MartinBelthle merged commit 00b3876 into dev Jan 31, 2024
6 checks passed
@MartinBelthle MartinBelthle deleted the fix-disk-usage-bug-on-variant branch January 31, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants