code smell 3

AntaresSimulatorTeam · Jun 17, 2024 · 72ed904 · 72ed904
1 parent 92cb511
commit 72ed904
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 25 deletions.
diff --git a/src/libs/antares/study/include/antares/study/parameters.h b/src/libs/antares/study/include/antares/study/parameters.h
@@ -50,21 +50,6 @@ namespace Antares::Data
 class Parameters final
 {
 public:
-    //! \name Constructor
-    //@{
-    /*!
-    ** \brief Default Constructor
-    **
-    ** \warning None of the variables are initialized. You must explicitly use
-    **   the method `reset()` or the method `loadFromFile()`
-    ** \see reset()
-    ** \see loadFromFile()
-    */
-    Parameters();
-    //! Destructor
-    ~Parameters();
-    //@}
-
     //! \name Simulation mode
     //@{
     //! Get if the simulation is in economy mode
@@ -504,7 +489,7 @@ class Parameters final
     //@{
     //! No output
     // This variable is not stored within the study but only used by the solver
-    bool noOutput;
+    bool noOutput = false;
     //@}
 
     bool hydroDebug;

diff --git a/src/libs/antares/study/load.cpp b/src/libs/antares/study/load.cpp
@@ -293,7 +293,7 @@ bool Study::internalLoadBindingConstraints(const StudyLoadOptions& options)
 class SetHandlerAreas
 {
 public:
-    SetHandlerAreas(Study& study):
+    explicit SetHandlerAreas(Study& study):
         pStudy(study)
     {
     }

diff --git a/src/libs/antares/study/parameters.cpp b/src/libs/antares/study/parameters.cpp
@@ -54,7 +54,7 @@ static bool ConvertCStrToListTimeSeries(const String& value, uint& v)
     }
 
     value.words(" ,;\t\r\n",
-                [&v](const AnyString& element) -> bool
+                [&v](const AnyString& element)
                 {
                     ShortString16 word(element);
                     word.toLower();
@@ -208,13 +208,6 @@ const char* SimulationModeToCString(SimulationMode mode)
     }
 }
 
-Parameters::Parameters():
-    noOutput(false)
-{
-}
-
-Parameters::~Parameters() = default;
-
 bool Parameters::economy() const
 {
     return mode == SimulationMode::Economy;