Implement latest CSR comments #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/keep-track-with-rte-develop
…/fix/execution-info-format Clarify execution-info.ini file
…/feature/cxx-17 Bump to CXX 17 from CXX 11
…#820) * execution_info.ini : add OR-Tools used & solver * PR remarks
…#793) * Fix wrong number of cores + code de-duplication * PR remarks + small refactor (template)
Issue-66 comment implementation
KEEP TRACK WITH RTE DEVELOP
flomnes
requested changes
Aug 24, 2022
src/solver/simulation/economy.h
Outdated
Comment on lines
63
to
64
| void solveCSR(Variable::State& state, uint numSpace, uint week); | ||
| private: |
There was a problem hiding this comment.
Suggested change
| void solveCSR(Variable::State& state, uint numSpace, uint week); | |
| private: | |
| private: | |
| void solveCSR(Variable::State& state, uint numSpace, uint week); |
Comment on lines
192
to
193
| std::unique_ptr<PROBLEME_POINT_INTERIEUR> Probleme | ||
| = buildInteriorPointProblem(ProblemeAResoudre); |
There was a problem hiding this comment.
Suggested change
| std::unique_ptr<PROBLEME_POINT_INTERIEUR> Probleme | |
| = buildInteriorPointProblem(ProblemeAResoudre); | |
| auto Probleme | |
| = buildInteriorPointProblem(ProblemeAResoudre); |
| @@ -505,8 +505,6 @@ struct AdequacyPatchParameters | |||
| float ThresholdDisplayLocalMatchingRuleViolations; | |||
There was a problem hiding this comment.
Use double for ThresholdInitiateCurtailmentSharingRule and ThresholdDisplayLocalMatchingRuleViolations
| { | ||
| std::unique_ptr<PROBLEME_POINT_INTERIEUR> Probleme(new PROBLEME_POINT_INTERIEUR()); |
There was a problem hiding this comment.
Suggested change
| std::unique_ptr<PROBLEME_POINT_INTERIEUR> Probleme(new PROBLEME_POINT_INTERIEUR()); | |
| auto Probleme = std::make_unique<PROBLEME_POINT_INTERIEUR>(); |
You need to merge branch develop for that, since it contains #779. This feature is only available from C++17.
flomnes
requested changes
Aug 24, 2022
CSR comments implementation update
flomnes
approved these changes
Aug 24, 2022
flomnes
merged commit d49872e
into
AntaresSimulatorTeam:feature/do-not-merge-csr-generate-executables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of RTE comments on CSR dev solution.
Issue 66 on RTEi repository.