Update Microsoft.CodeAnalysis to stable 1.3.2 #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ataReference.CreateFromFile
matthid
reviewed
Jul 1, 2017
| @@ -32,7 +32,7 @@ private class SelectMetadataReference : CompilerReference.ICompilerReferenceVisi | |||
| { | |||
| public MetadataReference Visit(Assembly assembly) | |||
| { | |||
| return MetadataReference.CreateFromAssembly(assembly); | |||
| return Visit(assembly.Location); | |||
There was a problem hiding this comment.
Maybe we should get rid from the Assembly-case ("CreateFromAssembly"). It is the an artefact from the hope of early Roslyn builds, which supported an in-memory assembly. But sadly that is no longer the case :(
I guess you mean |
|
Thanks for looking into this. Change looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MissingMethodExceptionsat runtime.For the next PR, would you be OK if I merged RazorEngine.CodeAnalysis.Roslyn into RazorEngine.CodeAnalysis as a next step for #436?
As an aside, I have migrated the code to .NET Standard 2.0 in my branch updateToNetCore and the tests for Roslyn work but many of the tests fail for RazorEngine.Core because there is no longer a default compiler factory being set.
Part of changes to support #414