Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiled js files and ts compiler config #3

Merged
merged 2 commits into from
Dec 14, 2016
Merged

compiled js files and ts compiler config #3

merged 2 commits into from
Dec 14, 2016

Conversation

harterc3
Copy link
Contributor

Added tsconfig.json file and included compiled ES5 js files since people were asking for it to be included in git repo.

@AnteWall
Copy link
Owner

Thanks for the PR!

I appreciate the pull request however i'm not entirely sure this will work with the npm package.
The package itself is only the src/lib folder to reduce the package size, so the corresponding files need to be added to src/lib/dist and a tsconfig.json to be able to be installed with the npm package

@harterc3
Copy link
Contributor Author

@AnteWall Thanks for the feedback! Good point on the lib folder. I put another commit in for compiling to lib/dist instead. Let me know if there is anything missing.

@AnteWall
Copy link
Owner

@harterc3 Looks good to me! Will merge and update the package during the day, thanks a lot for the PR!

closes #2

@AnteWall AnteWall merged commit b8a2565 into AnteWall:master Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants