GH-8 Shortcut out on id > extension_id

AntelopeIO · Apr 23, 2024 · 914f117 · 914f117
1 parent 484d40e
commit 914f117
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/libraries/chain/block.cpp b/libraries/chain/block.cpp
@@ -65,13 +65,16 @@ namespace eosio::chain {
       return results;
    }
 
+   // Does not validate ordering, assumes validate_and_extract_extensions() has been called in verify_qc_claim()
    std::optional<block_extension> signed_block::extract_extension(uint16_t extension_id)const {
       using decompose_t = block_extension_types::decompose_t;
 
       for( size_t i = 0; i < block_extensions.size(); ++i ) {
          const auto& e = block_extensions[i];
          auto id = e.first;
 
+         if (id > extension_id)
+            break;
          if (id != extension_id)
             continue;
 

diff --git a/libraries/chain/block_header.cpp b/libraries/chain/block_header.cpp
@@ -65,13 +65,16 @@ namespace eosio { namespace chain {
       return results;
    }
 
+   // Does not validate ordering, assumes validate_and_extract_header_extensions() has been called in block_state creation
    std::optional<block_header_extension> block_header::extract_header_extension(uint16_t extension_id)const {
       using decompose_t = block_header_extension_types::decompose_t;
 
       for( size_t i = 0; i < header_extensions.size(); ++i ) {
          const auto& e = header_extensions[i];
          auto id = e.first;
 
+         if (id > extension_id)
+            break;
          if (id != extension_id)
             continue;