GH-8 Add assert that extensions are sorted

libraries/chain/block.cpp

@@ -69,6 +69,8 @@ namespace eosio::chain {
    std::optional<block_extension> signed_block::extract_extension(uint16_t extension_id)const {
       using decompose_t = block_extension_types::decompose_t;
 
+      assert(std::ranges::is_sorted(block_extensions)); // currently all extensions are unique so default compare works
+
       for( size_t i = 0; i < block_extensions.size(); ++i ) {
          const auto& e = block_extensions[i];
          auto id = e.first;

libraries/chain/block_header.cpp

@@ -69,6 +69,8 @@ namespace eosio { namespace chain {
    std::optional<block_header_extension> block_header::extract_header_extension(uint16_t extension_id)const {
       using decompose_t = block_header_extension_types::decompose_t;
 
+      assert(std::ranges::is_sorted(header_extensions)); // currently all extensions are unique so default compare works
+
       for( size_t i = 0; i < header_extensions.size(); ++i ) {
          const auto& e = header_extensions[i];
          auto id = e.first;

libraries/chain/include/eosio/chain/block.hpp

@@ -79,7 +79,8 @@ namespace eosio { namespace chain {
    }
 
    using block_extension_types = detail::block_extension_types<
-         additional_block_signatures_extension, quorum_certificate_extension
+         additional_block_signatures_extension,
+         quorum_certificate_extension
    >;
 
    using block_extension = block_extension_types::block_extension_t;