Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace_api_plugin reports block trace missing when http-max-response-time-ms limit is reached #1433

Closed
heifner opened this issue Jul 20, 2023 · 0 comments · Fixed by #1449, #1468 or #1469
Closed
Assignees
Labels
bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team
Milestone

Comments

@heifner
Copy link
Member

heifner commented Jul 20, 2023

{"code":404,"message":"Trace API: block trace missing","error":{"code":0,"name":"","what":"","details":[]}}

https://github.com/AntelopeIO/leap/blob/v4.0.4/plugins/trace_api_plugin/abi_data_handler.cpp#L40 Calls except_handler when yield() throw exception and returns {}. The except_handler is setup to https://github.com/AntelopeIO/leap/blob/v4.0.4/plugins/trace_api_plugin/trace_api_plugin.cpp#L204 only log the error. This means a small http-max-response-time-ms causes trace_api_plugin to indicate it could not find the block rather than a deadline exception was hit.

@heifner heifner added the bug Something isn't working label Jul 20, 2023
@arhag arhag added this to the Leap v4.0.5 milestone Jul 20, 2023
@arhag arhag added 👍 lgtm and removed triage labels Jul 20, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Jul 24, 2023
heifner added a commit that referenced this issue Jul 25, 2023
@heifner heifner modified the milestones: Leap v4.0.5, Leap v3.2.5 Jul 26, 2023
heifner added a commit that referenced this issue Jul 28, 2023
heifner added a commit that referenced this issue Jul 28, 2023
[3.2] Modify trace_api_plugin to report serialization errors to user
heifner added a commit that referenced this issue Jul 28, 2023
heifner added a commit that referenced this issue Jul 28, 2023
heifner added a commit that referenced this issue Jul 31, 2023
[3.2 -> 4.0] Modify trace_api_plugin to report serialization errors to user
heifner added a commit that referenced this issue Jul 31, 2023
heifner added a commit that referenced this issue Jul 31, 2023
[4.0 -> main] Modify trace_api_plugin to report serialization errors to user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment