Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count field in get_table_by_scope response - Deprecate in v6 and remove in v7 #2091

Open
bhazzard opened this issue Jan 16, 2024 · 2 comments
Open

Count field in get_table_by_scope response - Deprecate in v6 and remove in v7 #2091

bhazzard opened this issue Jan 16, 2024 · 2 comments
Labels
👍 lgtm
Milestone
Leap v7.0.0

Comments

@bhazzard
Copy link

bhazzard commented Jan 16, 2024 •
edited
Loading

Issue #1174 - get_table_by_scope returns the table rows count wrongly reported that count is calculated incorrectly.

After discussion, we decided the best route forward is to remove this field rather than correct the calculation. The deprecation announcement has now been published. We will consider the field deprecated in v6.0.0, and remove it completely in Leap v7.0.0.

Timeline:

  • Deprecation announcement: 2024-01-17
  • Deprecated release: Leap v6.0.0
  • Removed release: Leap v7.0.0
@bhazzard bhazzard added 👍 lgtm and removed triage labels Jan 16, 2024
@bhazzard bhazzard changed the title Deprecate count from get_table_by_scope Remove count from get_table_by_scope Jan 16, 2024
@bhazzard bhazzard added this to the Leap v7.0.0 milestone Jan 16, 2024
@bhazzard
Copy link
Author

@bhazzard post a deprecation notice ASAP.

@bhazzard bhazzard changed the title Remove count from get_table_by_scope Removing count from get_table_by_scope Jan 17, 2024
@bhazzard bhazzard changed the title Removing count from get_table_by_scope Count field in get_table_by_scope response - Deprecate in v6 and remove in v7 Jan 17, 2024
@bhazzard
Copy link
Author

@bhazzard post a deprecation notice ASAP.

Done: https://github.com/AntelopeIO/leap/wiki/Deprecations-and-Proposed-Deprecations-In-Leap-Software

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👍 lgtm
Projects
Team Backlog
Status: Todo
Milestone
Leap v7.0.0
Development

No branches or pull requests
2 participants
@bhazzard @enf-ci-bot