Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned Builds in CI #735

Closed
Tracked by #41
kj4ezj opened this issue Feb 22, 2023 · 6 comments · Fixed by #1338 or #1339
Closed
Tracked by #41

Pinned Builds in CI #735

kj4ezj opened this issue Feb 22, 2023 · 6 comments · Fixed by #1338 or #1339
Assignees
Labels
CICD Anything dealing with the CI workflow behavior 👍 lgtm OCI Work exclusive to OCI team

Comments

@kj4ezj
Copy link
Contributor

kj4ezj commented Feb 22, 2023

Current Phase

Make the script runnable in CI as a quick/dirty immediate fix.

Acceptance Criteria

  1. Pinned builds use dependency versions defined by Leap engineers above the default version provided by a given platform (this is what is meant by "pinned")
  2. Pinned builds run in GitHub Actions

Future Plans (🚨OUT OF SCOPE)

Future Plans Take the existing pinned build scripts and run them in GitHub Actions. These builds will eventually be used for release assets, but attaching release assets should be a separate ticket.

I have been asked not to run this build on every push, but the desired trigger conditions are not well-defined. Some suggestions include on pushes/merges to release branches, pushes/merges to main, or perhaps event to leave this as a manual run for now. Any of these conditions are acceptable to complete this ticket.

Acceptance Criteria

  1. Pinned builds use dependency versions defined by Leap engineers above the default version provided by a given platform (this is what is meant by "pinned")
  2. Pinned builds run in GitHub Actions
  3. Pinned builds run on base branches, manually, or under specific trigger conditions
  4. Pinned builds do not run on feature branches by default
  5. Pinned builds generate binaries for supported platforms
  6. Pinned builds use existing build scripts with minor plumbing but not major changes
  7. Pinned builds are in addition to, not instead of, the existing "unpinned" build system
  8. Pinned builds run on our existing GCP runner fleet

See Also

  1. Pull Request 833 - Fix Pinned Build on Ubuntu 22.04
  2. Pull Request 812 - Pinned Build Script Linter Changes
  3. Pull Request 835 - Change ASCII Art Banner in Build Script
  4. Pull Request 832 - Roll install_deps.sh into pinned_build.sh
  5. Pull Request 847 - Restore libcurl4-openssl-dev
  6. Pull Request 849 - Fix README.md Formatting
  7. Pull Request 870 - Pinned Build Script Backport Omnibus
  8. Pull Request 857 - Simplify Pinned Build Scripts
  9. Pull Request 811 - Pinned Build Script Changes
@kj4ezj kj4ezj added the CICD Anything dealing with the CI workflow behavior label Feb 22, 2023
@kj4ezj kj4ezj self-assigned this Feb 22, 2023
@kj4ezj
Copy link
Contributor Author

kj4ezj commented Feb 22, 2023

This issue was brought to me by @wanderingbort.

@wanderingbort
Copy link
Contributor

using the existing code where possible

If this task cannot be completed without material changes to the pinned build scripts themselves then we should re-evaluate the scope. If this statement was more in the plumbing surrounding those scripts then 👍

@wanderingbort
Copy link
Contributor

I would like to add a requirement that this uses our existing fleet of runners if possible.

@bhazzard
Copy link

bhazzard commented Jun 1, 2023

Zach is engaged on other priorities, and won't be available anytime soon. This is urgent enough that it is worth doing a quick solution. Make the script runnable in CI as an immediate fix. We'll reassign.

@arhag
Copy link
Member

arhag commented Jun 1, 2023

Whoever takes this issue should talk to @kj4ezj to make sure hand-off occurs properly. Zach may have already done some work on this issue that shouldn't be duplicated.

@bhazzard
Copy link

Blocked pending completion of #1277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD Anything dealing with the CI workflow behavior 👍 lgtm OCI Work exclusive to OCI team
Projects
Archived in project
6 participants