[3.2 -> 4.0] Emit correct trace id for deferred trx before replace_deferred protocol feature activation #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re replace_deferred
…fer from provided packed_transaction for deferred trxs before replace_deferred protocol feature is activated.
[3.2] Emit correct trace id for deferred trx before replace_deferred protocol feature activation
greg7mdp
approved these changes
Jul 7, 2023
linh2931
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before protocol feature
replace_deferredis activated the trx id of the scheduled transaction can differ from the packed_transaction that is executed. This PR restores the behavior of tracking and reporting in transaction traces the scheduled transaction id instead of the packed_transaction id. This was not a consensus error but rather the wrong trx id was being reported in transaction traces for scheduled transactions before the on-chain activation ofreplaced_deferred. This manifested itself by confusing SHiP in recording the scheduled transactions reported in a block.Merges
release/3.2intorelease/4.0including #1379Resolves #1354