[4.0] SHiP: Fixes: Stack overflow, invalid index, split file access #1779

heifner · 2023-10-16T15:55:20Z

Includes three SHiP state_history_plugin fixes:

Fix for stack overflow due to recursive call to send(). Fixed by posting to the SHiP thread on new send()s.
Fix for accessing wrong data after log splitting.
Fix for accessing wrong file after log splitting.

Resolves #1677

…ve send()

…n index is at the wrong offset

plugins/state_history_plugin/include/eosio/state_history_plugin/session.hpp

linh2931

This PR fixes several issues. Can a test be added for each of them?

libraries/state_history/include/eosio/state_history/log.hpp

plugins/state_history_plugin/include/eosio/state_history_plugin/session.hpp

plugins/state_history_plugin/tests/session_test.cpp

…file descriptors seems like overkill and is difficult to follow/verify is correct.

linh2931 · 2023-10-18T15:49:52Z

libraries/state_history/include/eosio/state_history/log.hpp

-      }
-
-      new_log_file.close();
-      new_index_file.close();


like this simplification.

heifner added 4 commits October 13, 2023 15:23

GH-1677 Avoid stack overflow by posting to ship io_context on recursi…

fa5ff2f

…ve send()

GH-1677 Update index_begin_block on log split otherwise next lookup i…

1705e35

…n index is at the wrong offset

GH-1677 Close files as rename/swap was not working

5723fa9

GH-1677 Add assert and error message

b795fee

heifner requested review from greg7mdp and linh2931 October 16, 2023 15:55

heifner added the OCI Work exclusive to OCI team label Oct 16, 2023

heifner linked an issue Oct 16, 2023 that may be closed by this pull request

Leap 4.0.4 - Exception in SHiP thread pool #1677

Closed

linh2931 reviewed Oct 16, 2023

View reviewed changes

plugins/state_history_plugin/include/eosio/state_history_plugin/session.hpp Show resolved Hide resolved

linh2931 reviewed Oct 16, 2023

View reviewed changes

GH-1677 Add additional tests

f5b5e64

heifner requested a review from linh2931 October 17, 2023 15:43

linh2931 approved these changes Oct 17, 2023

View reviewed changes

greg7mdp reviewed Oct 18, 2023

View reviewed changes

heifner added 2 commits October 18, 2023 10:33

GH-1677 Simplify split_log function as the protection against out of …

a396da9

…file descriptors seems like overkill and is difficult to follow/verify is correct.

GH-1677 Use EOS_ASSERT instead of elog/assert

1cb6a9d

linh2931 reviewed Oct 18, 2023

View reviewed changes

linh2931 approved these changes Oct 18, 2023

View reviewed changes

greg7mdp approved these changes Oct 18, 2023

View reviewed changes

heifner merged commit 39327d8 into release/4.0 Oct 19, 2023
16 checks passed

heifner deleted the GH-1677-ship-4.0 branch October 19, 2023 12:32

This was referenced Oct 19, 2023

[4.0 -> 5.0] SHiP: Fixes: Stack overflow, invalid index, split file access #1798

Merged

[4.0] SHiP: Make sure we append to index file #1801

Merged

[5.0 -> main] SHiP: Fixes: Stack overflow, invalid index, split file access #1802

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.0] SHiP: Fixes: Stack overflow, invalid index, split file access #1779

[4.0] SHiP: Fixes: Stack overflow, invalid index, split file access #1779

heifner commented Oct 16, 2023

linh2931 left a comment

linh2931 Oct 18, 2023

[4.0] SHiP: Fixes: Stack overflow, invalid index, split file access #1779

[4.0] SHiP: Fixes: Stack overflow, invalid index, split file access #1779

Conversation

heifner commented Oct 16, 2023

linh2931 left a comment

Choose a reason for hiding this comment

linh2931 Oct 18, 2023

Choose a reason for hiding this comment