Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Revert "Fix base64 encoding" #1886

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

heifner
Copy link
Member

@heifner heifner commented Nov 10, 2023

Reverts #1482 as it causes issues with backward compatibility with older version of nodeos. See #1883.
An alternative fix will be provided in a follow-on PR.

Re-open #1461
Resolves #1883

@heifner heifner added the OCI Work exclusive to OCI team label Nov 10, 2023
@heifner heifner merged commit de71459 into release/5.0 Nov 13, 2023
29 checks passed
@heifner heifner deleted the GH-1883-base64-rm-5.0 branch November 13, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.0 cleos cannot handle reponses from pre-5.0 nodes containing base64 (and vice versa I believe)
3 participants