Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] always run the long running tests, including for pull requests #221

Merged
merged 2 commits into from
Sep 24, 2022

Conversation

spoonincode
Copy link
Member

@spoonincode spoonincode commented Sep 23, 2022

Currently we only run LR tests for merges to main or release branches, as well as when manually requested. Due to our usage of the "All Required Tests Passed" test as a branch protect rule we can go ahead and enable these LR tests to always run and still not block merging should a PR be approved and need to merge before LR tests complete.

Based on some experimentation:

  • If the PR is approved before "All Required Tests Passed" completes successfully, the merge button remains disabled (with an admin override option for some of us).
  • If a PR is approved before or after "All Required Tests Passed" completes successfully, but before LR tests complete, the merge button is "white" -- this still allows merging.
  • Once LR tests complete successfully the merge button additionally goes green.
  • If a LR test fails, the merge button will remain white.

The last scenario is a bit unfortunate. Still, this change would seem to provide more information (more test feedback) in the times we don't need to rush a PR in within ~10 minutes, but still allow anyone to merge PRs quickly before LR tests complete when they feel its appropriate.

@spoonincode spoonincode added the CICD Anything dealing with the CI workflow behavior label Sep 23, 2022
arhag
arhag previously approved these changes Sep 23, 2022
arhag
arhag previously approved these changes Sep 23, 2022
@arhag arhag dismissed their stale review September 23, 2022 17:31

Done testing

@spoonincode spoonincode changed the title always run the long running tests, including for pull requests [3.2] always run the long running tests, including for pull requests Sep 23, 2022
@spoonincode spoonincode merged commit c665605 into main Sep 24, 2022
@spoonincode spoonincode deleted the always_test_lr branch September 24, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD Anything dealing with the CI workflow behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants