Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple problems in cli_test #37

Merged
merged 3 commits into from
Aug 22, 2022
Merged

fix multiple problems in cli_test #37

merged 3 commits into from
Aug 22, 2022

Conversation

spoonincode
Copy link
Member

Fixes multiple issues I've encountered with cli_test:

  • don't assume builddir is a subdirectory of sourcedir, resolves cli_test assumes build directory is subdirectory of source directory #30. All the needed files are already in the builddir so this is literally just removing a needless ..
  • remove a deceptive print() of an error. It's always an error and it's intended to be an error
  • use makedirs() to ensure all parent directories are created. This is needed when the test if the first (or only) test to run, such as when running all the tests in parallel. Otherwise the var/ directory doesn't exist and the test errors out.

@spoonincode spoonincode merged commit 820a063 into main Aug 22, 2022
@spoonincode spoonincode deleted the cli_test_fixes branch August 22, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli_test assumes build directory is subdirectory of source directory
2 participants