[3.2] replace git commands from nodeos' & launcher's cmake with libversion usage #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
reviewed
Aug 30, 2022
| @@ -12,4 +12,9 @@ namespace eosio { namespace version { | |||
| return version; | |||
| } | |||
|
|
|||
| const std::string& version_hash() { | |||
| static const std::string vhash{_version_hash()}; | |||
There was a problem hiding this comment.
Seems like an odd thing to keep around for the life of the application. Looks like a copy paste from above, but the same thing goes for those as well.
There was a problem hiding this comment.
Yeah I was just following how it was done before, it does seem unnecessary
There was a problem hiding this comment.
@heifner is refactoring libversion something you want to see done?
There was a problem hiding this comment.
Not a huge priority, so this is fine for now.
heifner
changed the title
heifner
approved these changes
Aug 30, 2022
heifner
pushed a commit
that referenced
this pull request
Apr 29, 2024
Integration test for configuration where producer and finalizer nodes are separate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libversion is the canonical method by which components should be retrieving the build version. But both nodeos' & eosio-launcher's CMakeLists were running git to retrieve a version. Remove that and replace with libversion usage instead. libversion needed a method added to retrieve the git hash as nodeos' get_info server_version returns the first 4 bytes of the git hash.