Use constants instead hardcoded numbers in view pagers adapters

AntennaPod · Apr 10, 2020 · 53b51de · 53b51de
1 parent 3b1737e
commit 53b51de
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/app/src/main/java/de/danoeh/antennapod/fragment/EpisodesFragment.java b/app/src/main/java/de/danoeh/antennapod/fragment/EpisodesFragment.java
@@ -57,12 +57,12 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
 
         new TabLayoutMediator(tabLayout, viewPager, (tab, position) -> {
             switch (position) {
-                case POS_ALL_EPISODES:
-                    tab.setText(R.string.all_episodes_short_label);
-                    break;
                 case POS_NEW_EPISODES:
                     tab.setText(R.string.new_episodes_label);
                     break;
+                case POS_ALL_EPISODES:
+                    tab.setText(R.string.all_episodes_short_label);
+                    break;
                 case POS_FAV_EPISODES:
                     tab.setText(R.string.favorite_episodes_label);
                     break;
@@ -94,7 +94,7 @@ public void onStart() {
         viewPager.setCurrentItem(lastPosition);
     }
 
-    public class EpisodesPagerAdapter extends FragmentStateAdapter {
+    static class EpisodesPagerAdapter extends FragmentStateAdapter {
 
         EpisodesPagerAdapter(@NonNull Fragment fragment) {
             super(fragment);
@@ -104,11 +104,12 @@ public class EpisodesPagerAdapter extends FragmentStateAdapter {
         @Override
         public Fragment createFragment(int position) {
             switch (position) {
-                case 0:
+                case POS_NEW_EPISODES:
                     return new NewEpisodesFragment();
-                case 1:
+                case POS_ALL_EPISODES:
                     return new AllEpisodesFragment();
                 default:
+                case POS_FAV_EPISODES:
                     return new FavoriteEpisodesFragment();
             }
         }

diff --git a/app/src/main/java/de/danoeh/antennapod/fragment/preferences/StatisticsFragment.java b/app/src/main/java/de/danoeh/antennapod/fragment/preferences/StatisticsFragment.java
@@ -80,10 +80,10 @@ public static class StatisticsPagerAdapter extends FragmentStateAdapter {
         @Override
         public Fragment createFragment(int position) {
             switch (position) {
-                case 0:
+                case POS_LISTENED_HOURS:
                     return new PlaybackStatisticsFragment();
                 default:
-                case 1:
+                case POS_SPACE_TAKEN:
                     return new DownloadStatisticsFragment();
             }
         }