overide "downloading on battery" for manual updates

[HolgerJeromin]

I would suggest a change:
On manual feed update AND episodes are ready to download AND on battery AND "Download when not charging" prefs is NOT set
Antennapod should ask the user:

New episode could be downloaded, but you are on battery. 
[download], [download always], [no]

I tend to forget the reason why the download is not performed, so a manual update should override the prefs or inform me about this situation.

[mfietz]

When Download when not charging is set and you are on battery (not charging), why should the app even ask and not start downloading right away?

[HolgerJeromin]

Because I forgot about the preference (again) :-)
It took me half an hour to debug the missing downloads, while hammering the reload button...

[HolgerJeromin]

Ups. Added a negation in the post...

[TomHennen]

I'm confused, you can still manually click to download whatever episodes you want. The feeds still get refreshed with a manual refresh and show all the episodes to be downloaded in New Episodes. Why not just go there and download the ones you're looking for? Or don't select the Download when not charging option?

Alternatively, we could add a 'Download All' option to 'New Episodes'. I'm not sure I like the idea of having it prompt the user. It's certainly not the behavior I'd want.

[HolgerJeromin]

The prefs is called pref_automatic_download_on_battery.
The question is: if i click the "refresh" button, is the following download a manual or a automatic download?
In my feeling it is a manual download, as it was triggered ultimately by me.
In your opinion it could be a automatic download, as is was triggered by new available episodes and not directly by a click.

If you disagree with me i am fine with closing this issue.

I never use the 'new episodes' view or download episodes by hand, as i rely on antennapod to find and download all episodes for me.

[mfietz]

IMHO you are triggering the refresh. The complete refresh then may trigger the automatic download, so the automatic downloads are caused by you rather indirectly.

Still, it may be a good idea to have some sort of indicator that auto download is enabled, but is currently not performed because of $reason
We only have to find a good place for that