Recycler view for Episodes Fragment #1336

TomHennen · 2015-11-04T03:27:24Z

This swaps our use of DSLV for recycler view in the Episodes Fragment.

We SHOULD NOT merge this in for 1.4. Instead this will be targeted for the next version where we can build on in for RecyclerView in the Queue.

I've integrated the use of SnackBar as demonstrated by @mfietz. Ideally we'd do something more like this: https://github.com/hudomju/android-swipe-to-dismiss-undo, but we'd need it to be compatible with api 10.

…king

@mfietz

@mfietz, https://github.com/mfietz/AntennaPod/blob/recyclerview/app/src/main/java/de/danoeh/antennapod/fragment/AllEpisodesFragment.java

…ason

mfietz · 2015-11-04T12:23:43Z

app/src/main/java/de/danoeh/antennapod/adapter/AllEpisodesRecycleAdapter.java


    private final Context context;
    private final ItemAccess itemAccess;
    private final ActionButtonCallback actionButtonCallback;
    private final ActionButtonUtils actionButtonUtils;
    private final boolean showOnlyNewEpisodes;
+    private final MainActivity mainActivity;


Should not really cause an activity leak (as long as we set the adapter in the activity to null), but I could sleep better if this was a WeakReference

mfietz · 2015-11-04T12:46:51Z

Just had an idea to get rid of the stupid AllEpisodesFragment constructor warning. We simply change the attributes to methods.
AllEpisodesFragment:

private boolean showOnlyNewEpisodes() { return false; }
private String getPrefName() { return DEFAULT_PREF_NAME; }

NewEpisodesFragment:

@Override
private boolean showOnlyNewEpisodes() { return true; }
@Override
private String getPrefName() { return PREF_NAME; }

mfietz · 2015-11-04T12:52:56Z

app/src/main/java/de/danoeh/antennapod/fragment/AllEpisodesFragment.java

-        progLoading = (ProgressBar) root.findViewById(R.id.progLoading);
+        listView = (RecyclerView) root.findViewById(android.R.id.list);
+        layoutManager = new LinearLayoutManager(getActivity());
+        listView.setLayoutManager(layoutManager);


listView.setHasFixedSize(true);

listView → recyclerView?

Also, you can take https://github.com/mfietz/AntennaPod/blob/recyclerview/app/src/main/java/de/danoeh/antennapod/view/DividerItemDecoration.java and

RecyclerView.ItemDecoration itemDecoration = new DividerItemDecoration(getActivity(), null); listView.addItemDecoration(itemDecoration);

mfietz · 2015-11-04T12:55:38Z

Fresh develop installation, one feed subscribed, short playing around in episodes, upgrade to this PR:

java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.Float
    at android.app.SharedPreferencesImpl.getFloat(SharedPreferencesImpl.java:254)
    at de.danoeh.antennapod.fragment.AllEpisodesFragment.restoreScrollPosition(AllEpisodesFragment.java:184)
    at de.danoeh.antennapod.fragment.AllEpisodesFragment.onFragmentLoaded(AllEpisodesFragment.java:326)
    at de.danoeh.antennapod.fragment.AllEpisodesFragment.lambda$loadItems$41(AllEpisodesFragment.java:414)
    at de.danoeh.antennapod.fragment.AllEpisodesFragment.access$lambda$1(AllEpisodesFragment.java)
    at de.danoeh.antennapod.fragment.AllEpisodesFragment$$Lambda$2.call(Unknown Source)
    at rx.Observable$31.onNext(Observable.java:7593)
    at rx.observers.SafeSubscriber.onNext(SafeSubscriber.java:130)
    at rx.internal.operators.OperatorObserveOn$ObserveOnSubscriber.pollQueue(OperatorObserveOn.java:208)
    at rx.internal.operators.OperatorObserveOn$ObserveOnSubscriber$2.call(OperatorObserveOn.java:170)
    at rx.internal.schedulers.ScheduledAction.run(ScheduledAction.java:55)
    at android.os.Handler.handleCallback(Handler.java:733)
    at android.os.Handler.dispatchMessage(Handler.java:95)
    at android.os.Looper.loop(Looper.java:136)
    at android.app.ActivityThread.main(ActivityThread.java:5001)
    at java.lang.reflect.Method.invokeNative(Native Method)
    at java.lang.reflect.Method.invoke(Method.java:515)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
    at dalvik.system.NativeStart.main(Native Method)

mfietz · 2015-11-04T12:56:52Z

app/src/main/java/de/danoeh/antennapod/fragment/AllEpisodesFragment.java

-            editor.putInt(PREF_KEY_LIST_SELECTION, 0);
-            editor.putInt(PREF_KEY_LIST_TOP, 0);
+            editor.putInt(PREF_SCROLL_POSITION, 0);
+            editor.putInt(PREF_SCROLL_OFFSET, 0);


editor.putFloat(PREF_SCROLL_OFFSET, 0.0f);

TomHennen · 2015-11-04T23:12:44Z

app/src/main/java/de/danoeh/antennapod/fragment/FavoriteEpisodesFragment.java

+                    Snackbar snackbar = Snackbar.make(root, getString(R.string.removed_item),
+                            Snackbar.LENGTH_LONG);
+                    snackbar.setAction(getString(R.string.undo), v -> {
+                        DBWriter.addFavoriteItem(item);


Unfortunately this doesn't put it back in the same position it was in before, that may be confusing.

This is probably the solution, however we'd have to update our supportlib use to 23 to get it: http://stackoverflow.com/a/32190462/6839

(though someone else suggests a hack/workaround to use in the meantime). That could be promising. It would also get rid of the runnable business we have to do for NewEpisodesFragment.

hm, couldn't we just create an Pair<FeedItem,Integer> that also holds the position and submit that to snackbar for undo?

We're not really tracking position in favorites at this point. It mostly reflects the order you added things. Not sure I want to worry about order just to resolve this issue.

Another solution, which might make more sense anyways, is to sort the items in Favorites. We could use the date the item was published or just sort alphabetically by title.

If you want to get started on this (and you think it's minimally acceptable) you could merge now while we work on this solution in another issue/PR.

TomHennen · 2015-11-05T11:52:21Z

After discussion with @mfietz we're going to get this in to 1.4 since DSLV is causing crashes for people.

Recycler view for Episodes Fragment

TomHennen added 9 commits November 3, 2015 21:40

playing around with recycler view. context menu and swiping isn't wor…

8f5e0bb

…king

undo for favorites

7489046

undo for new items

a02b84d

replaced context menu with popup menu. still a couple of other issues

89bbc88

resolved compilation problem and got rid of the 'no items' label

f9ef32f

remove commented out code

10ee9ba

Fixed saving/restoration of scroll position thanks to some code from

e555b3f

@mfietz, https://github.com/mfietz/AntennaPod/blob/recyclerview/app/src/main/java/de/danoeh/antennapod/fragment/AllEpisodesFragment.java

can't use the support version construct for recycler view for some re…

358a96e

…ason

switched to snackbar

910363c

TomHennen added the awaiting review label Nov 4, 2015

TomHennen added this to the FUTURE milestone Nov 4, 2015

mfietz reviewed Nov 4, 2015
View reviewed changes

addressed some of mfietz's comments

d66384b

TomHennen reviewed Nov 4, 2015
View reviewed changes

don't remove the media if they undo

e03ef16

TomHennen removed the awaiting review label Nov 5, 2015

TomHennen modified the milestones: 1.4, FUTURE Nov 5, 2015

TomHennen added a commit that referenced this pull request Nov 5, 2015

Merge pull request #1336 from TomHennen/recycler_view

3b003c6

Recycler view for Episodes Fragment

TomHennen merged commit 3b003c6 into AntennaPod:develop Nov 5, 2015

TomHennen deleted the recycler_view branch November 22, 2015 16:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Recycler view for Episodes Fragment #1336

Recycler view for Episodes Fragment #1336

TomHennen commented Nov 4, 2015

mfietz Nov 4, 2015

mfietz commented Nov 4, 2015

mfietz Nov 4, 2015

mfietz commented Nov 4, 2015

mfietz Nov 4, 2015

TomHennen Nov 4, 2015

TomHennen Nov 4, 2015

mfietz Nov 4, 2015

TomHennen Nov 5, 2015

TomHennen Nov 5, 2015

TomHennen commented Nov 5, 2015

Recycler view for Episodes Fragment #1336

Recycler view for Episodes Fragment #1336

Conversation

TomHennen commented Nov 4, 2015

Choose a reason for hiding this comment

mfietz commented Nov 4, 2015

Choose a reason for hiding this comment

mfietz commented Nov 4, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomHennen commented Nov 5, 2015