-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player screen design update #3856
Player screen design update #3856
Conversation
2dbc33b
to
fe632a4
Compare
I think it's time to update the playback button layout on the player. Right now, they are laid out in 1 line as if they are equally important to the end user when they are actually not, and some buttons are up at the top right when they should be closer to the user's hand below. My suggestions:
I think those 4 steps would make for a much more modern, hand-friendly player UI that works better on the increasingly large and taller screens we are seeing today. Antennapod's current UI was fine back in the Android 2.x days when screens were relatively small, but not anymore. |
There still are the horizontal tabs with shownotes and chapters. Making the button row higher makes it harder to reach the tabs.
I tried that and did not like it. So I reverted back to the same size. I will experiment with a bordered button I do not want to do a full redesign like what you are suggesting. I just want to make it look a bit more modern without being a ton of work and destroying user's muscle memory. |
I am undecided about this one. Could be handy to have the slider available when browsing shownotes. Anyway, the current code design assumes that the button is always there. Removing it would require to restructure big parts of the playback screen. Restructuring the screen would also be needed for something like #2353 but I currently do not have time for that.
This is currently too much work for me. Contributions welcome, though. |
Fair enough. My other player idea #3847 is probably too much work as well. You're probably already aware, but you may want to use the "help wanted" github label for any issues you're interested in implementing but don't have time for. Since there's no major player changes to be made other than the bordered play button, I think your "after" image looks fine to me. I still think the "next track button" should be done away with entirely, though, since it doesn't mark the current podcast as played or delete the downloaded file, but that's just my opinion. |
That's basically every issue :D I added "good first issue" to some issues but except from Hacktober, it did not increase the number of contributions too much.
Should be pretty easy with a Toast message but I don't need this personally, so I am not too motivated to do it (even if it only takes half an hour) |
The play button looks better but I'm not sure why the buttons are slightly closer together. I think that just makes it more likely for people to hit the wrong button, but maybe its not close enough for that to happen. |
The circle has no padding and therefore, the outer buttons looked like they had more distance than the other buttons. I don't think this increases the risk of hitting the wrong button. |
Feedback welcome.
Closes #3723
Closes #3793
Before/After: