Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seek bar issues #5142

Merged
merged 4 commits into from
May 9, 2021
Merged

Seek bar issues #5142

merged 4 commits into from
May 9, 2021

Conversation

jonasburian
Copy link
Contributor

@jonasburian jonasburian commented May 3, 2021

This fixes issues of the seek bar, mentioned in #4915

  • Buffering indicator drawn incorrectly
  • Not refreshing divider positions with duration change
  • Seeking to first chapter not reliable

I'm not sure about the third one. In my testing, the seeking worked every time (the same as via the chapters page). The only thing that was a bit strange is the highlighting, but I'm not sure (yet) how to solve that.

@ByteHamster
Copy link
Member

I'm not sure about the third one. In my testing, the seeking worked every time (the same as via the chapters page). The only thing that was a bit strange is the highlighting, but I'm not sure (yet) how to solve that.

You are right - I was fooled by a display glitch. Jumping itself actually works.

The only thing that was a bit strange is the highlighting

When pressing the second and third chapter's section on my test feed, the thumb jumps to the beginning of that chapter immediately. When pressing the first one, the thumb stays where it is, highlights the chapter that was playing last and only gets set to the correct position on the next position update event. Hmm. Not sure why this happens.

@ByteHamster ByteHamster merged commit 508cea6 into AntennaPod:develop May 9, 2021
@ByteHamster
Copy link
Member

Thanks!

@jonasburian jonasburian deleted the seekbar-fixes branch May 9, 2021 17:24
@antennapod-bot
Copy link

This pull request has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/antennapod-2-3-0-release-notes/1047/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants