Remove Jetifier (checklist)

[TacoTheDank]

Checklist

• I have used the search function for open and closed issues to see if someone else has already submitted the same feature request.
• I will describe the problem with as much detail as possible.
• This request contains only one single feature, not a list of multiple (related) features.

App version

2.6.0

Where did you get the app from

Google Play

Problem you may be having, or feature you want

As you probably know, the android.enableJetifier=true flag automatically migrates dependencies using old support libraries to AndroidX. However, this also slows down build times. We can speed up the building by being able to get rid of this flag (from some sources I've found, this provides a non-insignificant performance improvement).

Fortunately, there is a new gradle check in AGP 7.x.x that allows us to check what libraries are still using Jetifier. For this purpose, all I did was bump the AGP version to 7.2.1 and run ./gradlew checkJetifier. It returns these results (I cleaned up the output manually to make it easier to read):

The following libraries used by project ':app' depend on legacy support libraries.
To disable Jetifier, you will need to use AndroidX-supported versions of these libraries.

com.github.bumptech.glide:glide:4.8.0 -> com.android.support:support-annotations:27.1.1

com.joanzapata.iconify:android-iconify:2.2.2 -> com.android.support:support-v4:22.2.1

com.github.shts:TriangleLabelView:1.1.2 -> com.android.support:appcompat-v7:24.2.0

Suggested solution

Here are my suggestions for each library:

• Glide - Update the library to at least 4.10.0, where they migrated to AndroidX.
• Iconify - This one will be the most difficult as there is no direct solution or replacement (also, it is unmaintained and outdated). We will have to find some replacement for this library.
• TriangleLabelView - As this library is composed of a single small class, I would suggest simply integrating the class into one of the .view class directories (either the app submodule or the ui:common submodule).

I made them checkboxes so they can be checked off as they're completed.

Screenshots / Drawings / Technical details

No response

[ByteHamster]

Iconify - This one will be the most difficult as there is no direct solution or replacement (also, it is unmaintained and outdated). We will have to find some replacement for this library.

I think we only use that library in very few places. It can probably be replaced with TextView compound drawables in most cases

[TacoTheDank]

Mm, sounds good. I'll look into that.