Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to import from Google Podcast OPML export #6884

Closed
4 tasks done
z-olpin opened this issue Jan 19, 2024 · 17 comments
Closed
4 tasks done

Unable to import from Google Podcast OPML export #6884

z-olpin opened this issue Jan 19, 2024 · 17 comments
Labels
Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet

Comments

@z-olpin
Copy link

z-olpin commented Jan 19, 2024

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same bug report.
  • I have also used the search function for CLOSED issues to see if the problem is already solved and just waiting to be released.
  • I will describe the problem with as much detail as possible.
  • If the bug only to occurs with a certain podcast, I will include the URL of that podcast.

App version

3.2.0

Where did you get the app from

Google Play

Android version

14

Device model

Google Pixel 6a

First occurred

Today

Steps to reproduce

  1. Create or export an OPML file with an unescaped ampersand in the title of one of the podcasts. The podcast in question for me is "Mind & Matter" and the entity looks like: <outline xmlUrl="https://mindandmatter.substack.com/feed" type="rss" text="Mind & Matter" />
  2. Attempt to import the OPML file

Note: I'm aware this is Google failing to export a valid OPML file, but with many people switching from the soon-to-be shuttered Google Podcasts, AntennaPod may wish to try and pick up the slack on their end so as to not immediately turn away potential users. As it stands, I imagine most people would give up on AntennaPod immediately if they are unable to import their subscriptions.

Google Podcasts is pushing users to use YouTube Music, and it's worth noting that exporting the same subscriptions to YouTube Music does work.

Leaving this issue hoping to increase volume of users who will switch from Google Podcasts to AntennaPod, but please close if this issue is not appropriate since it's somewhere between a bug and a feature request, and is, again, ultimately a problem with Google Podcasts OPML export, not AntennaPod.

Expected behaviour

  • The unescaped ampersand is identified and corrected while parsing the XML, OR,
  • The problematic entity is ignored and that podcast skipped (ideally not silently)

Current behaviour

An error dialog appears with the message below and no subscriptions are imported.

An error has occurred while reading the OPML document:unterminated entity ref (position:START_TAG <outline xmlUrl='https://mindandmatter.substack.com/feed' type='rss' text=Two Psychologists, Four Beers'> @1:3732 in java.io.InputStream Reader@acc8e1 6)

Screenshot:
Screenshot_20240118-230635

Logs

No response

@z-olpin z-olpin added the Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet label Jan 19, 2024
@z-olpin
Copy link
Author

z-olpin commented Jan 19, 2024

I'm on mobile and unfamiliar with this repo, but I believe a relatively simple addition to the file core/src/main/java/de/danoeh/antennapod/core/export/opml/OpmlReader.java could "fix" this problem (or perhaps more appropriately, implement this functionality)

@z-olpin z-olpin changed the title Unable to import from Google Podcast OMPL export Unable to import from Google Podcast OPML export Jan 19, 2024
@tonytamsf
Copy link
Member

tonytamsf commented Jan 21, 2024

I think Google engineers have fixed this problem. I verified with Google Podcasts app , subscribed the feed you mentioned and exported OPML and xmllint and imported to AP. You can try exporting again from the latest version of Google Podcasts 1.0.0.562912592

@tonytamsf
Copy link
Member

I've closed the issue, if you think it needs to be reopened, I can contact Google employees

@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/can-i-bring-google-podcasts-over-since-they-are-going-away/3808/18

@shawnwright
Copy link

You've closed this but I'm having this same issue. I downloaded my OPML from google less than 10 minutes ago and am getting the same error as the OP.

Screenshot_20240123_121625_AntennaPod

@shawnwright
Copy link

For what it's worth, I do not get an error when I import the same OPML into pocket casts.

@tonytamsf
Copy link
Member

Thanks @shawnwright . What version of Google Podcasts are you running?

@shawnwright
Copy link

shawnwright commented Jan 24, 2024 via email

@tonytamsf
Copy link
Member

@shawnwright - would you be willing to email me your OPML file? engineer.tonytam@gmail.com

@tonytamsf
Copy link
Member

@shawnwright, can you still let me know the version of the Google Podcasts app? I think it's in the setting screen.

@shawnwright
Copy link

shawnwright commented Jan 24, 2024 via email

@RagingSquirrel
Copy link

I have the same issue with Google Takeout too.

Screenshot_20240330-211416

@keunes
Copy link
Member

keunes commented Mar 30, 2024

@RagingSquirrel The original issue normally is fixed. Also the error message seems to be different from what's been reported before.

Could I ask you, therefore, to create a new bug report with all the details? If you're willing to, attaching the export from TakeOut would be helpful. If not publicly, you may send it to [my username]@mailbox.org and I'll test myself and pass it on to the relevant people if needed.

@nikau6
Copy link

nikau6 commented May 2, 2024

Still not working for me. Google's opml files are corrupt. You can't read them with any opml reader on the web. They don't want you to use something else than Google Music.

@keunes
Copy link
Member

keunes commented May 2, 2024

Hi @nikau6, sorry to hear about that. Same request for you as in my previous comment: please create a new issue, ideally attaching your OPML file so it can be investigated.

@DigiFink
Copy link

DigiFink commented May 8, 2024

I had the same issue and found out that Google generates a faulty OPML file when exporting.
For example:
<outline xmlUrl="https://example.com/feed/mp3" type="rss" text="foo & bar" />
instead of:
<outline xmlUrl="https://example.com/feed/mp3" type="rss" text="foo &amp; bar" />

"&" is a reserved character in XML files and marks the beginning of a character entity. If you want to use the "&" character in the text attribute, it must be written as "&am;" instead.
I didn't find any other reserved characters in the text attribute of my OPML file, but you might find some in yours.

Reserved characters and its named entities:

&: &amp;
<: &lt;
>: &gt;
": &quot; 
': &apos; 

I manually corrected the OPML file in a text editor. After that, it was importable with AntennaPod.

This error only occurs when using the web version of Google Podcasts for exporting the opml file. The current mobile app appears to create a valid file.

@keunes
Copy link
Member

keunes commented May 8, 2024

Google generates a faulty OPML file when exporting.
"&" is a reserved character in XML files
This error only occurs when using the web version of Google Podcasts for exporting the opml file. The current mobile app appears to create a valid file.

Thanks @DigiFink for sharing that insight! @tonytamsf do you think we could get that message to Google engineers? In the meantime, I'll update our blog post on the website to recommend using the in-app export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet
Projects
None yet
Development

No branches or pull requests

8 participants