Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1073. crash on oneplus two(Android 5.1.1, Oxygen 2.0.0). #1076

Merged
merged 1 commit into from Aug 15, 2015

Conversation

waylife
Copy link
Contributor

@waylife waylife commented Aug 10, 2015

fix issue #1073. crash on oneplus two(Android 5.1.1, Oxygen 2.0.0).
#1073

@TomHennen
Copy link
Contributor

Great. Thanks for submitting this. I won't be able to properly review it
for a few days but I'll definitely get to it.

On Mon, Aug 10, 2015, 11:07 AM RxRead notifications@github.com wrote:

fix issue #1073 #1073.
crash on oneplus two(Android 5.1.1, Oxygen 2.0.0).

#1073 #1073

You can view, comment on, or merge this pull request online at:

#1076
Commit Summary

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1076.

@TomHennen TomHennen self-assigned this Aug 15, 2015
@TomHennen TomHennen added this to the FUTURE milestone Aug 15, 2015
@TomHennen
Copy link
Contributor

Seems to work well enough. Hopefully we'll get this out for 1.3.1. Once it's in alpha testing you should be able to pick it up then.

TomHennen added a commit that referenced this pull request Aug 15, 2015
fix issue #1073. crash on oneplus two(Android 5.1.1, Oxygen 2.0.0).
@TomHennen TomHennen merged commit 269d54d into AntennaPod:develop Aug 15, 2015
@TomHennen TomHennen modified the milestones: 1.3.1, FUTURE, 1.3.2 Aug 15, 2015
@waylife
Copy link
Contributor Author

waylife commented Aug 16, 2015

Great!

@TomHennen
Copy link
Contributor

BTW, it will actually be 1.3.2. There was an emergency fix that had to go
out. Didn't have time to vet this through alpha testing.

On Sat, Aug 15, 2015, 10:41 PM RxRead notifications@github.com wrote:

Great!


Reply to this email directly or view it on GitHub
#1076 (comment)
.

@waylife
Copy link
Contributor Author

waylife commented Aug 16, 2015

Seems I have to use a custom apk before the alpha testing.

@TomHennen
Copy link
Contributor

@waylife, This should be in the alpha version that just got pushed to the play store. Sorry it took so long.

@waylife
Copy link
Contributor Author

waylife commented Aug 23, 2015

It is okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants