Rewind after pause feature

[stefan-mitrik]

This pull request resolves #620 feature request.

The playback is rewinded X seconds after the pause and resume. The rewind duration depends on time that elapsed between the pause and resume. User is not able to customize the rewind duration right now.

I have chosen following constants (can be easily changed):

• podcast rewinds:
  • 0 seconds - if pause < 3 minutes
  • 2 seconds - if pause > 3 minutes
  • 5 seconds - if pause > 1 hour
  • 10 seconds - if pause > 1 day

I have chosen these constants based on my gut feelings and observation of the other apps such as Audible.

[TomHennen]

This is great. Just tested it out and everything seems fine.

I do wonder if the values are too conservative?

What do people (like yourself and @mfietz) think about something like:

• 0 seconds if pause < 1 minute
• 3 seconds if pause > 1 minute
• 10 seconds if pause > 1 hour
• 20 seconds if pause > 1 day?

[mfietz]

Why not have settings for that? :>

[TomHennen]

What would be a good way to configure the setting? Letting them configure
each of those 6 values would probably be too much.

On Fri, Oct 16, 2015, 5:16 PM Martin Fietz notifications@github.com wrote:

Why not have settings for that? :>

—
Reply to this email directly or view it on GitHub
#1260 (comment)
.

[stefan-mitrik]

I was thinking about simple checkbox that turns rewind on/off. Then we could use less conservative values so users can turn it off if it annoys them.

However I believe that most of the people will find rewind useful as almost everyone looses context after some time.

[mfietz]

I was kidding when I suggested settings ;)
I wouldn't even let the users deactivate it. Most users won't even notice, this would really be unnecessary

[ChaoticMind]

I too think the original values are a bit too conservative, and prefer Tom's values. Thanks for the PR!

[stefan-mitrik]

I do agree. So I have pushed a commit with less conservative values.

[TomHennen]

Excellent. Thanks @stevomit!

[Matth7878]

I feel like 20 secs rewind after one day is too much time and I think it is noticeable.
It should either rewind 10 secs or rewind 20 secs but after 1,5 days => I'm sure a lot of people will have their own preferences. It's why I think users should be at least able to turn it off or better be able to set their own value.

[forteller]

Fantastic! Thanks, @stevomit! This is (almost exactly) what I wanted in #620. :)