Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndroidTest fixes due to PR #3322 #3356

Merged
merged 2 commits into from
Aug 31, 2019

Conversation

orionlee
Copy link
Contributor

Fixed androidTest compilation errors introduced in #3322

@orionlee
Copy link
Contributor Author

Also add :app:assemblePlayDebugAndroidTest in CircleCI build so that it can proactively detect similar issues going forward

@ByteHamster
Copy link
Member

You are back! Thanks a lot :)

@ByteHamster ByteHamster merged commit ac9ca32 into AntennaPod:develop Aug 31, 2019
@orionlee
Copy link
Contributor Author

@ByteHamster I would be available going forward. If there is anything specific you'd like me to look at, feel free to contact me.

@ByteHamster
Copy link
Member

I don't really have anything specific. Do you use the gpodder.net integration? Maybe that could need some love. Especially #3346 and #2711. To be honest, I am not too motivated because I do not use the feature myself and I am not familiar with the synchronization code base. In the long term, it would be great to have more services for synchronization, so creating an abstraction for synchronization services would be great.

That's a huge task, though. Just working through the issues list would help a lot, too. In the last few weeks, I managed to get from 380 open issues down to 299 🎉. If you want to start to work on something that might be a lot of work, please comment there before starting.

@orionlee
Copy link
Contributor Author

orionlee commented Sep 2, 2019

I don't use gpodder.net, so I can't quite help there.

In short term, I will focus on areas I've touched and small bugs on issues list. My PR #3045 and #2714 would also close a few issues. :-)
In particular, #3045 is a bug fix that could still make sense for v1.7.3 . #2714, with new preference, is probably too late for the game.

@ByteHamster
Copy link
Member

#3045 looks like it could lead to problems if we overlook anything. I don't want to add such changes before the next update. Just crashes and direct regressions (like #3367, #3363).

@orionlee
Copy link
Contributor Author

orionlee commented Sep 2, 2019

hmm, I agree that #3045 such probably be included in the beginning of the release cycle (beta tested) so it's too late for 1.7.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants