Fix locale of every String.format number formatter

[ebraminio]

Split from #4020, searched %d, %.1f, %.2f entire the project to see if locale String.format has correct locale, which includes fixes on some SQL query fixes on locales don't use 123 digits (۱۲۳), URL builders that should've used 123 in any locale, improvements on logs.

Rule of thumb, use Locale.getDefault() everywhere string goes directly to view and use Locale.US (or Locale.ENGLISH, the former was used by the project already) every other place like building a SQL query or URL (and maybe logs as they are in English anyway)

[ebraminio]

They were using Locale.getDefault() by default but Android lint, correctly, asks to make requested locale explicit.

[ByteHamster]

Woah, looks like the current production version is really broken in languages that do not use western Arabic numbers... Thanks a lot for your contribution!

Would you be interested in changing other occurrences of numbers, too? While trying your PR, I noticed that the following locations still use western Arabic numbers:

• File size
• Episode numbers in the sidebar
• Episode numbers on the subscriptions screen
• (Episode count in the queue infobar) I will change that when reworking String concatenation

[ebraminio]

Would you be interested in changing other occurrences of numbers, too? While trying your PR, I noticed that the following locations still use western Arabic numbers:

Sure! Did one of them bcb529e wanted to add another PR for it.

Woah, looks like the current production version is really broken in languages that do not use western Arabic numbers... Thanks a lot for your contribution!

It isn't that bad. AntennaPod was my main podcast player for several months without hitting these issues or I was ignoring them unknowingly anyway. You should've seen this particular issue on Google Play crash analytics however I believe, I use that for discovering my FOSS app issues which the app itself doesn't have internet access let alone other Google-y things as it is provided by Google Play for all the apps.

[ebraminio]

File size

This should be used https://developer.android.com/reference/kotlin/android/text/format/Formatter#formatShortFileSize(android.content.Context,%20kotlin.Long) which is totally localized.

Episode numbers in the sidebar

By bcb529e but guess we should inspect every String.valueOf.

Episode numbers on the subscriptions screen

Guess was covered by d938ed2 not sure however, probably is another String.valueOf use.

[ByteHamster]

Sure! Did one of them bcb529e wanted to add another PR for it.

So can we merge this one or do you want to add those changes here?

[ebraminio]

Yes, feel free to merge this. Thanks!

…

On Thu, Apr 9, 2020, 02:09 H. Lehmann ***@***.***> wrote: Sure! Did one of them bcb529e <bcb529e> wanted to add another PR for it. So can we merge this one or do you want to add those changes here? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4021 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGLPQNPG23Y5UDXY4MSYFDRLTVIVANCNFSM4MEEWU7Q> .

[ByteHamster]

Thanks a lot for your PR!