Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spinner to time_dialog to allow the user to opt into permitting… #4826

Commits on Jan 1, 2021

  1. Added spinner to time_dialog to allow the user to opt into permitting…

    … shake to reset (sleep timer) at any time during the sleep timer.
    
    Addresses issue (AntennaPod#4824)
    Addresses issue (AntennaPod#4825)
    
    Details:
    	The spinner defaults to "During fadeout" to preserve the original behaviour. If the user opts into the new behaviour by selecting "Anytime" from the spinner, they can shake the reset the sleep timer at any time during the countdown, rather than only during the fadeout. I think this is especially userful for users who do not use the "vibrate" feature of the sleep timer, as the audio fadeout alone can be quite subtle and easily missed.
    	This also fixes an issue with the existing sleep timer behaviour - currently the sleep timer will not respect the user unchecking the "shake to reset" option during the fadeout, as the ShakeListener has already been registered, and the callback does not check if the user has enabled shake to reset.
    Thom-Merrilin committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    93fff84 View commit details
    Browse the repository at this point in the history