Add preference to show subscription title #5538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbh
force-pushed
the
tile-name
branch
2 times, most recently
from
87811cc
to
7d050dd
Compare
|
When the cover is not loaded yet (try clearing the cache), it shows another random color that the View had before. I think it should be set to gray during loading. When the image cannot be loaded (404, etc), the text is white on light gray, which is pretty hard to read. |
ByteHamster
reviewed
Nov 17, 2021
core/src/main/java/de/danoeh/antennapod/core/preferences/UserPreferences.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/adapter/SubscriptionsRecyclerAdapter.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/adapter/SubscriptionsRecyclerAdapter.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/adapter/SubscriptionsRecyclerAdapter.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/adapter/CoverLoader.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/adapter/CoverLoader.java
Outdated
Show resolved
Hide resolved
Use dark text color when the dominant color is too light
ByteHamster
reviewed
Nov 28, 2021
core/src/main/java/de/danoeh/antennapod/core/glide/PaletteBitmapResource.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/danoeh/antennapod/core/glide/PaletteBitmapResource.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/danoeh/antennapod/core/glide/PaletteBitmapResource.java
Outdated
Show resolved
Hide resolved
|
Thanks! Will be in version 2.5.0 :) |
|
This pull request has been mentioned on AntennaPod Forum. There might be relevant details there: https://forum.antennapod.org/t/antennapod-2-5-release-notes/1636/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5415
Added a preference to display subscription title and changed the title
TextViewbackground to the dominant color in the subscription cover image instead of transparent background.