Remove no longer needed compat methods

[TacoTheDank]

With the recent bump of the minimum supported OS version from 16 to 19 (which makes me pretty happy), there are quite a few compat methods we no longer need to use, as the internal checks they do are for versions below 19.

Some side notes:

• AppCompatResources.getDrawable calls AppCompatDrawableManager.get().getDrawable internally, and is what's supposed to be used anyway.
• CompareCompat.compareLong's code was (or the comments were) incorrect for some reason. The greater than and less than symbols were flipped and didn't match up with the method's comments, causing the actual behavior to be equal to Long.compare(long2, long1) instead of Long.compare(long1, long2) like the comments say. I can only assume that was a mistake by the original contributor. Should I also flip these, then, since that was the behavior of the removed method?

[ByteHamster]

AppCompatResources.getDrawable calls AppCompatDrawableManager.get().getDrawable internally, and is what's supposed to be used anyway.

Do you have an official source for that? The function does not look like we are supposed to use it directly and this SO post says it's not part of the public API.
https://stackoverflow.com/a/40242172/4193263

[TacoTheDank]

The post is saying that AppCompatDrawableManager.get().getDrawable(Context, int) isn't part of the public API, not AppCompatDrawable.getDrawable (which does not exist, which leads me to believe they meant AppCompatResources.getDrawable).

Anyway, AppCompatDrawableManager.get().getDrawable(Context, int) is not part of the public API.

Furthermore, AppCompatResources.getDrawable calls ContextCompat.getDrawable internally.
https://developer.android.com/reference/androidx/appcompat/content/res/AppCompatResources#getDrawable(android.content.Context,%20int)

[ByteHamster]

causing the actual behavior to be equal to Long.compare(long2, long1) instead of Long.compare(long1, long2) like the comments say. I can only assume that was a mistake by the original contributor. Should I also flip these, then, since that was the behavior of the removed method?

Yeah, I think that would be good. The behavior should not be changed. The change currently breaks the statistics screens.

The post is saying that AppCompatDrawableManager.get().getDrawable(Context, int) isn't part of the public API, not AppCompatDrawable.getDrawable

Oh, right. Sorry. I somehow mixed up the additions vs deletions and thought you are doing the exact opposite. Your change is obviously what we want/should do 👍

[TacoTheDank]

No worries lol. I'll get to flipping the compares when I can :)

[TacoTheDank]

@ByteHamster Done 👍

[ByteHamster]

Thanks!

[antennapod-bot]

This pull request has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/antennapod-2-5-release-notes/1636/1